Skip to content
This repository has been archived by the owner on Jun 8, 2023. It is now read-only.

✨ Split signals into triggers and guards #247

Open
wants to merge 23 commits into
base: development
Choose a base branch
from
Open

✨ Split signals into triggers and guards #247

Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
bca116a
separation of signals into triggers and guards
raftersvk Jan 10, 2022
33064bd
Merge branch 'separation-of-signals-into-triggers-and-guards' of http…
raftersvk Jan 10, 2022
c8ae749
update installer.sh to specific branch / easy test setup
raftersvk Jan 11, 2022
67205f2
code improvment and new default min/max value for 1st HO run
raftersvk Jan 11, 2022
6419f80
Merge branch 'separation-of-signals-into-triggers-and-guards' of http…
raftersvk Jan 11, 2022
2f8a95b
hyperopt parameter : in case min == max value no need to optimize
raftersvk Jan 12, 2022
014c238
indent correction
raftersvk Jan 12, 2022
faeea55
new configurable signal weight search space and generic rework of the…
raftersvk Jan 15, 2022
060dff2
individual hyperoptable weighted signal space
raftersvk Jan 19, 2022
adf3e5b
Merge branch 'development' of https://github.com/Rikj000/MoniGoMani i…
raftersvk Jan 20, 2022
d50a87d
further changes for triggers/guards and individual weighted signals s…
raftersvk Jan 21, 2022
f5adec0
Merge branch 'Rikj000:development' into separation-of-signals-into-tr…
raftersvk Jan 21, 2022
9ad503a
sample mgm-config for better HO results
raftersvk Jan 22, 2022
e3170ed
Merge branch 'separation-of-signals-into-triggers-and-guards' of http…
raftersvk Jan 22, 2022
e8e9527
Remove unneeded finta import
raftersvk Jan 27, 2022
0e0bcba
⚡️ Optimized imports & fixed indentation
Rikj000 Jan 30, 2022
6439b51
⚡️ Improved nested if-or block notation
Rikj000 Jan 30, 2022
3d51d81
⚡️ Fixed typo
Rikj000 Jan 30, 2022
cd66d38
♻️ Some minor refactors
Rikj000 Jan 30, 2022
314eb59
bug correction + improvments on populating dataframe
raftersvk Feb 2, 2022
7133e5b
Merge branch 'separation-of-signals-into-triggers-and-guards' of http…
raftersvk Feb 2, 2022
2c76774
Add buy and sell triggers' names into buy_tag / exit_tag
raftersvk Feb 3, 2022
0d94374
code beautifuling and small sell reason correction
raftersvk Mar 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions installer.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@
# /usr/bin/env sh <(curl -s "https://raw.githubusercontent.com/Rikj000/MoniGoMani/development/installer.sh")
#
# === Settings =========================================================================================================
INSTALL_FOLDER_NAME="Freqtrade-MGM" # By default the folder will be created under the current working directory
MGM_REPO_URL="https://github.com/Rikj000/MoniGoMani.git"
MGM_BRANCH="development"
INSTALL_FOLDER_NAME="Freqtrade-MGM-Raftersvk" # By default the folder will be created under the current working directory
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can remain until right before we're going to merge since it does allow for easily testing the PR,
but we should undo this when the PR is ready to merge!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you this is only a temporary change

MGM_REPO_URL="https://github.com/raftersvk/MoniGoMani_raftersvk.git"
MGM_BRANCH="separation-of-signals-into-triggers-and-guards"
MGM_COMMIT=""
SHELL_CONFIGS=(
~/.bashrc
Expand Down
18 changes: 9 additions & 9 deletions user_data/mgm-config.example.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,15 @@
"sell_trades_when_upwards": true
},
"weighted_signal_spaces": {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mgm-config changes are very welcome! However they should go in a separate PR.

With a set of test results from before & after the mgm-config changes so that it becomes clear if they bring improvements & what they improve exactly 🙂

It also would be preferred to split up multiple mgm-config changes into multiple PRs,
so we truly have a clear overview of what improves what exactly! 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I understand the idea to trace properly each change with a single PR.
These are the changes I made to my own mgm-config in order to get better profitable results, or to reduce/improve HO time without loosing much on quality.
not sure when I will find the time to "document" all those changes separately.
maybe somebody else can take this task ?

"sell_profit_only": true,
"sell_profit_only": false,
"min_weighted_signal_value": 0,
"max_weighted_signal_value": 100,
"min_trend_total_signal_needed_value": 60,
"max_weighted_signal_value": 20,
"min_trend_total_signal_needed_value": 10,
"min_trend_total_signal_needed_candles_lookback_window_value": 1,
"max_trend_total_signal_needed_candles_lookback_window_value": 8,
"min_trend_signal_triggers_needed": 2,
"search_threshold_weighted_signal_values": 22,
"search_threshold_trend_total_signal_needed_candles_lookback_window_value": 1,
"min_trend_signal_triggers_needed": 1,
"search_threshold_weighted_signal_values": 2,
"search_threshold_trend_total_signal_needed_candles_lookback_window_value": 3,
"search_threshold_trend_signal_triggers_needed": 1
},
"stoploss_spaces": {
Expand Down Expand Up @@ -161,13 +161,13 @@
}
},
"dry_run": true,
"dry_run_wallet": 500,
"dry_run_wallet": 1000,
"max_open_trades": -1,
"stake_currency": "USDT",
"stake_amount": 45,
"stake_amount": 300,
"tradable_balance_ratio": 0.99,
"amount_reserve_percent": 0.05,
"amend_last_stake_amount": false,
"amend_last_stake_amount": true,
"last_stake_amount_min_ratio": 0.5,
"cancel_open_orders_on_exit": false,
"use_sell_signal": true,
Expand Down
Loading