Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
php://stdin
orphp://input
depends on SAPI.getallheaders()
instead of$_SERVER
gloabl variable.getallheaders()
polyfill.1) Fix usage
STDIN
constant as parameter default value in \Riverline\MultiPartParser\Converters\Globals::convert().STDIN
constant defined only in CLI SAPI so when it used in other SAPI it produce notice like:Use of undefined constant STDIN - assumed 'STDIN' in ...
.2) Use
php://stdin
orphp://input
depends on SAPI.Use
php://stdin
if SAPI containscli
string. Not sure that it was rigth way, but it's better then before :)3) Create Header of temporary stream by
getallheaders()
instead of$_SERVER
gloabl variable.Iterating over $_SERVER global variable instantinate multiple
Content-Type
headers, because in some configurations$_SERVER
contains bothHTTP_CONTENT_TYPE
andCONTENT_TYPE
keys. Therefore header with keycontent-type
becomes an array. So in \Riverline\MultiPartParser\StreamedPart::parseHeaderContent() an Error will thown on$parts = explode(';', $content);
.4) Add
getallheaders()
polyfill.In some configurations
getallheaders()
could be not defined.