fix possible IndexOutOfRangeException on FabricVersionLoader.cs, Quil…

…tVersionLoader.cs
RiversideValley · Apr 26, 2022 · bd0a949 · bd0a949
1 parent 8401241
commit bd0a949
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/CmlLib/Core/Installer/FabricMC/FabricVersionLoader.cs b/CmlLib/Core/Installer/FabricMC/FabricVersionLoader.cs
@@ -35,9 +35,10 @@ private async Task<MVersionCollection> internalGetVersionMetadatasAsync(bool syn
                 else
                     loaders = await GetFabricLoadersAsync().ConfigureAwait(false);
 
-                LoaderVersion = loaders[0].Version;
-                if (loaders.Length == 0 || string.IsNullOrEmpty(LoaderVersion))
+                if (loaders.Length == 0 || string.IsNullOrEmpty(loaders[0].Version))
                     throw new KeyNotFoundException("can't find loaders");
+
+                LoaderVersion = loaders[0].Version;
             }
 
             string url = "https://meta.fabricmc.net/v2/versions/game/intermediary";

diff --git a/CmlLib/Core/Installer/QuiltMC/QuiltVersionLoader.cs b/CmlLib/Core/Installer/QuiltMC/QuiltVersionLoader.cs
@@ -35,9 +35,10 @@ private async Task<MVersionCollection> internalGetVersionMetadatasAsync(bool syn
                 else
                     loaders = await GetQuiltLoadersAsync().ConfigureAwait(false);
 
-                LoaderVersion = loaders[0].Version;
-                if (loaders.Length == 0 || string.IsNullOrEmpty(LoaderVersion))
+                if (loaders.Length == 0 || string.IsNullOrEmpty(loaders[0].Version))
                     throw new KeyNotFoundException("can't find loaders");
+
+                LoaderVersion = loaders[0].Version;
             }
 
             string url = "https://meta.quiltmc.org/v3/versions/game";