Remove unnecessary allocations in 64 bit BSI #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@guymolinari Can you review? |
|
@guymolinari This is a small PR and it looks ok, but I'd prefer if it were independently reviewed. Can you have a look? |
|
Yes.
…On Thu, Aug 24, 2023 at 10:20 AM Daniel Lemire ***@***.***> wrote:
@guymolinari <https://github.com/guymolinari> This is a small PR and it
looks ok, but I'd prefer if it were independently reviewed. Can you have a
look?
—
Reply to this email directly, view it on GitHub
<#394 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADZZAURYBPZMFUAQYAPXBILXW55OPANCNFSM6AAAAAA3HZUPDY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
guymolinari
approved these changes
Aug 24, 2023
|
Cheers @guymolinari |
|
Merged. Thanks @guymolinari |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A performance improvement I made after Bitmap allocation became the most significant performance issue after fixing #383. This avoids allocating bitmaps all over the heap and packs them together in the BSI for a good performance boost.
There's a small change to when RunOptimize is called, I found the existing behaviour was incorrect after extensive testing. This is probably related to my observation in #383 (comment).
This fix is picked from my production branch at https://github.com/anacrolix/roaring/tree/anacrolix.