Minor fixes, changes to FrozenBitmap
API (renaming)
#406
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestConcurrent*
instructions, we have no such tests.go fmt
.FrozenBitmap
errors are renamed according to the standard which indicates that their names should start withErr
. So we are changing our public API with respect naming which might cause some code brokerage, but it should be a minor inconvenience and the frozen API is for advanced users only.There are other issues that
go vet
exposes, but this PR will not solve these. Pull requests are invited (@joenall), they are:I do not understand these warnings, or rather I do not think that they indicate that something is actually wrong with the code. They are pedantic warnings. It is not immediately obvious what to do about those.
Fixes #405