points returns Iter, not Vec #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distances. Caused by rounding error in division. Fixed by
subtracting f64::EPSILON from the calculated segment length
before passing into densify.
feature: adds `LineStringSegmentizeHaversine` to provide geographic
support for segmentizing linestrings.
misc: segmentize traits are now implemented via a macro. This will
make it easier to add additional segmentize traits in the future.
A geodesic one would be preferable but would require a new
densify trait.
Integrate `spade`
Add `len()` and `is_empty()` to MultiPoint.
prepare for geo-types 0.7.12 release
`use-rstar_0_11` feature flag.
Prepare for 0.27.0 release
Expand on the technical definition for users not familiar with the term "set-theoretic intersection".
issue #1084: panics on haversine_closest_point
Improve documentation of `clip`
michaelkirk
force-pushed
the
mkirk/integrate-spade-coords-iter
branch
2 times, most recently
from
15be4fd to
3fd831d
Compare
Add LineStringSegmentizeHaversine
michaelkirk
force-pushed
the
mkirk/integrate-spade-coords-iter
branch
from
3fd831d to
f55e977
Compare
michaelkirk
force-pushed
the
mkirk/integrate-spade-coords-iter
branch
2 times, most recently
from
e2bd59b to
c611d0c
Compare
FIX: SpadeTriangulation was not actually configurable
This is an internal API, so we can safely break the API.
Bench output:
```
TriangulateSpade (unconstrained) - small polys
time: [8.7534 ms 8.7641 ms 8.7777 ms]
change: [-2.6587% -2.1965% -1.7360%] (p = 0.00 < 0.05)
Performance has improved.
Found 5 outliers among 100 measurements (5.00%)
3 (3.00%) high mild
2 (2.00%) high severe
Benchmarking TriangulateSpade (constrained) - small polys: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 98.7s, or reduce sample count to 10.
TriangulateSpade (constrained) - small polys
time: [986.61 ms 987.03 ms 987.51 ms]
change: [-5.2413% -5.0808% -4.9190%] (p = 0.00 < 0.05)
Performance has improved.
Found 17 outliers among 100 measurements (17.00%)
7 (7.00%) high mild
10 (10.00%) high severe
TriangulateEarcut - small polys
time: [6.9938 ms 6.9993 ms 7.0041 ms]
change: [-1.3566% -0.9176% -0.5312%] (p = 0.00 < 0.05)
Change within noise threshold.
Found 12 outliers among 100 measurements (12.00%)
5 (5.00%) low severe
5 (5.00%) low mild
2 (2.00%) high mild
TriangulateSpade (unconstrained) - large_poly
time: [3.4280 ms 3.4390 ms 3.4521 ms]
change: [+0.2922% +0.7947% +1.3032%] (p = 0.00 < 0.05)
Change within noise threshold.
Found 13 outliers among 100 measurements (13.00%)
7 (7.00%) high mild
6 (6.00%) high severe
Benchmarking TriangulateSpade (constrained) - large_poly: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 178.3s, or reduce sample count to 10.
TriangulateSpade (constrained) - large_poly
time: [1.7869 s 1.8005 s 1.8178 s]
change: [-7.9992% -5.8498% -4.2765%] (p = 0.00 < 0.05)
Performance has improved.
Found 14 outliers among 100 measurements (14.00%)
5 (5.00%) high mild
9 (9.00%) high severe
TriangulateEarcut - large_poly
time: [2.2287 ms 2.2346 ms 2.2413 ms]
change: [+1.0859% +1.4903% +1.9614%] (p = 0.00 < 0.05)
Performance has regressed.
Found 14 outliers among 100 measurements (14.00%)
10 (10.00%) high mild
4 (4.00%) high severe
```
michaelkirk
force-pushed
the
mkirk/integrate-spade-coords-iter
branch
from
c611d0c to
aa71ffd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.