Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Japanese translation. #63

Merged
merged 2 commits into from
Jan 6, 2025
Merged

Add Japanese translation. #63

merged 2 commits into from
Jan 6, 2025

Conversation

khara02
Copy link

@khara02 khara02 commented Apr 17, 2024

add Japanese translation.

@RobertD502
Copy link
Owner

Thank you!!

I added a few extra keys and used ChatGPT in order to get this ready for the release. Feel free to open a PR to fix them in case they are wrong.

@RobertD502 RobertD502 merged commit 4fc36d6 into RobertD502:main Jan 6, 2025
2 checks passed
@khara02
Copy link
Author

khara02 commented Jan 6, 2025

Thank you!!

I added a few extra keys and used ChatGPT in order to get this ready for the release. Feel free to open a PR to fix them in case they are wrong.

Thank you for your confirmation.
Regarding the "extra keys," the phrasing for "enhanced_adsorption" feels slightly unnatural in Japanese. Since I am not sure what kind of key it refers to, I am unsure how to translate it optimally.
The other keys seem to have natural Japanese translations.

@RobertD502
Copy link
Owner

Keys as in JSON keys so in this case I was referring to the keys enhanced_adsorption and use_ble_relay. Needed to have the contents of those two keys translated.

  • For use_ble_relay the following text was translated: Use PetKit BLE relay (if available)
  • For enhanced_adsorption, the following text was translated: Enhanced adsorption

@khara02
Copy link
Author

khara02 commented Jan 6, 2025

Keys as in JSON keys so in this case I was referring to the keys enhanced_adsorption and use_ble_relay. Needed to have the contents of those two keys translated.

  • For use_ble_relay the following text was translated: Use PetKit BLE relay (if available)
  • For enhanced_adsorption, the following text was translated: Enhanced adsorption

As a Japanese translation for "enhanced_adsorption," I feel that "吸着強化" (adsorption enhancement) is a better fit.

@RobertD502
Copy link
Owner

Thank you! I don't speak the language so I can't argue with that haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants