Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use entity references instead of id holding constants #2234

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Use entity references instead of id holding constants #2234

merged 2 commits into from
Dec 3, 2024

Conversation

RobinTail
Copy link
Owner

@RobinTail RobinTail commented Dec 3, 2024 •
edited
Loading

This should ease further improvements like #2226, reduce the amount of declarations and improve overall readability

@RobinTail RobinTail added the refactoring The better way to achieve the same result label Dec 3, 2024
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Dec 3, 2024 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same
when pulling 81985ea on no-const-id
into 33ede7c on master.

RobinTail
RobinTail commented Dec 3, 2024
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@RobinTail RobinTail marked this pull request as ready for review December 3, 2024 18:38
@RobinTail RobinTail merged commit 8c12668 into master Dec 3, 2024
11 checks passed
@RobinTail RobinTail deleted the no-const-id branch December 3, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
refactoring The better way to achieve the same result
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@RobinTail