Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching to ESM-first dual package (CJS remains) #318

Merged
merged 5 commits into from
Dec 15, 2023
Merged

Switching to ESM-first dual package (CJS remains) #318

merged 5 commits into from
Dec 15, 2023

Conversation

RobinTail
Copy link
Owner

No description provided.

@RobinTail RobinTail added enhancement New feature or request CI/CD labels Dec 15, 2023
@RobinTail RobinTail added this to the v2 milestone Dec 15, 2023
@RobinTail RobinTail mentioned this pull request Dec 15, 2023
Merged
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 15, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7227966414

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 7227782564: 0.0%
Covered Lines: 9
Relevant Lines: 9
💛 - Coveralls

@RobinTail RobinTail added the dependencies Pull requests that update a dependency file label Dec 15, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 15, 2023 •
edited
Loading

Performance benchmark

c660182

yarn run v1.22.21
$ /home/runner/work/merge-sx/merge-sx/node_modules/.bin/tsx tools/benchmark.ts
┌────────────────────────┬──────────┬─────────┬────────┬───────┐
│        (index)         │    10    │   100   │  1000  │ 10000 │
├────────────────────────┼──────────┼─────────┼────────┼───────┤
│ Current implementation │ 13305781 │ 1306276 │ 128916 │ 14783 │
└────────────────────────┴──────────┴─────────┴────────┴───────┘
Done in 21.70s.

RobinTail
RobinTail commented Dec 15, 2023
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@RobinTail RobinTail merged commit 5d90dae into prepare-v2 Dec 15, 2023
1 check passed
RobinTail added a commit that referenced this pull request Dec 15, 2023
@RobinTail
v2 (#313)
a2f0390 
- #312 
- #314 
  - made it 1.6 times faster
- #315  
- #316 
  - also replaced `npmignore` with `files` in `package.json`
- #317  
- #318 
- #319
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CI/CD dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
v2
Development

Successfully merging this pull request may close these issues.
1 participant
@RobinTail