Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cleanup] Remove unused packages in the repository #221

Merged
merged 1 commit into from
Sep 1, 2024
Merged

[cleanup] Remove unused packages in the repository #221

merged 1 commit into from
Sep 1, 2024

Conversation

davidcalderon03
Copy link
Member

@davidcalderon03 davidcalderon03 commented Sep 1, 2024 •
edited
Loading

Description

This PR does the following:

  • Removes urc_control package (which contains no content besides a README)
  • Removes urc_analysis package (which is a skeleton package and contains no source code)
  • Removes the "research" folder from the "documents" folder (since it is empty and not likely to be used, since we will be using Google Docs for documentation/research).

Testing Steps

  • colcon build

Expectation: The remaining packages should still build.

Self Checklist

  • I have formatted my code using ament_uncrustify --reformat
  • I have tested that the new behavior works

@davidcalderon03 davidcalderon03 self-assigned this Sep 1, 2024
@davidcalderon03 davidcalderon03 added the type/refactor Refactors a section of the codebase label Sep 1, 2024
yambati03
yambati03 approved these changes Sep 1, 2024
View reviewed changes
Copy link
Contributor

@yambati03 yambati03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidcalderon03 davidcalderon03 merged commit e8d794d into master Sep 1, 2024
4 of 5 checks passed
@davidcalderon03 davidcalderon03 deleted the cleanup/unused_packages branch September 1, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yambati03 yambati03 yambati03 approved these changes

Assignees

@davidcalderon03 davidcalderon03

Labels
type/refactor Refactors a section of the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidcalderon03 @yambati03