Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add location to F2F payment option (backend) #867
Add location to F2F payment option (backend) #867
Changes from 4 commits
b6b94c2
9e53f41
718a228
8cbe1af
f5cb0f7
9a1266e
eb462ec
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bond_size
was generated together withmakemigrations
, not sure if it was just missing or a mistake on my sideThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not a mistake, but it is an undesired change. It is best to delete lines L39 to L51 before merging (that is
migrations.AlterField(...)
. Alternatively, you can also delete the migration file, edit.env
toMIN_BOND_SIZE = 2
(instead of current value of 1) and the runmanage.py makemigrations
again. Should yield the same migration without altering the fieldbond_size
.The reason why this happened is that
/api/models/order.py
Order fieldbond_size
depends on two config parameters that are read from the.env
file. In my setup the.env
file defines theMIN_BOND_SIZE
as 2%, while the.env-sample
defines it as 1% (at some point, there was a deviation, I changed my own.env
without updating the.env-sample
...). This migration will therefore allow bond sizes to be smaller than the current minimum of 2%.I have opened a new issue (#873) so we make sure backend models are not dependant on any coordinator specific setting (
.env
) and therefore, we do not have any sort of conflict at run time when coordinators change values on their.env
file.