Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give the test more time to shut down #115

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

jwnimmer-tri
Copy link
Contributor

@jwnimmer-tri jwnimmer-tri commented Jan 23, 2025

CI has been seeing some flakes with the 1 second timeout.


This change is Reviewable

CI has been seeing some flakes with the 1 second timeout.
@jwnimmer-tri
Copy link
Contributor Author

+@SeanCurtis-TRI for all reviews, please.

Copy link
Contributor

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:LGTM: X2

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee SeanCurtis-TRI (waiting on @jwnimmer-tri)

@SeanCurtis-TRI SeanCurtis-TRI merged commit cddd55c into RobotLocomotion:main Jan 23, 2025
2 checks passed
@jwnimmer-tri jwnimmer-tri deleted the test-flake branch January 23, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants