Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] Drop CI requirement for DISPLAY #95

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

jwnimmer-tri
Copy link
Contributor

@jwnimmer-tri jwnimmer-tri commented Oct 25, 2024

See also RobotLocomotion/drake#22197 for related changes.


This change is Reviewable

@jwnimmer-tri jwnimmer-tri changed the title [examples] Drop CI requirement for xvfb server [examples] Drop CI requirement for DISPLAY Oct 25, 2024
@jwnimmer-tri jwnimmer-tri force-pushed the xorg branch 3 times, most recently from 98b4b9e to 714809d Compare October 31, 2024 02:05
@jwnimmer-tri jwnimmer-tri force-pushed the xorg branch 3 times, most recently from a1cd3c4 to cf53244 Compare October 31, 2024 14:09
@jwnimmer-tri
Copy link
Contributor Author

+@SeanCurtis-TRI for reviews, please.

Copy link
Contributor

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:LGTM:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion (waiting on @jwnimmer-tri)


examples/ball_bin.yaml line 65 at r1 (raw file):

    renderer_class: !RenderEngineVtkParams
      backend: EGL
    # For `show_rgb: True` you must also set the `backend: GLX` on prior line.

BTW Given this is used in CI, a further note indicating that this change should only be for local invocations of the test and it should never be commited as GLX?

Copy link
Contributor Author

@jwnimmer-tri jwnimmer-tri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 unresolved discussion (waiting on @SeanCurtis-TRI)


examples/ball_bin.yaml line 65 at r1 (raw file):

Previously, SeanCurtis-TRI (Sean Curtis) wrote…

BTW Given this is used in CI, a further note indicating that this change should only be for local invocations of the test and it should never be commited as GLX?

I want to keep this file aimed at users as its audience (not us maintainers), but I think I found a way to clarify the comment that helps the users, too.

Copy link
Contributor

@SeanCurtis-TRI SeanCurtis-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all discussions resolved, LGTM from assignee SeanCurtis-TRI (waiting on @jwnimmer-tri)

@jwnimmer-tri jwnimmer-tri merged commit d218789 into RobotLocomotion:main Nov 18, 2024
2 checks passed
@jwnimmer-tri jwnimmer-tri deleted the xorg branch November 18, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants