-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[examples] Drop CI requirement for DISPLAY #95
Conversation
98b4b9e
to
714809d
Compare
a1cd3c4
to
cf53244
Compare
+@SeanCurtis-TRI for reviews, please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion (waiting on @jwnimmer-tri)
examples/ball_bin.yaml
line 65 at r1 (raw file):
renderer_class: !RenderEngineVtkParams backend: EGL # For `show_rgb: True` you must also set the `backend: GLX` on prior line.
BTW Given this is used in CI, a further note indicating that this change should only be for local invocations of the test and it should never be commited as GLX?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 unresolved discussion (waiting on @SeanCurtis-TRI)
examples/ball_bin.yaml
line 65 at r1 (raw file):
Previously, SeanCurtis-TRI (Sean Curtis) wrote…
BTW Given this is used in CI, a further note indicating that this change should only be for local invocations of the test and it should never be commited as GLX?
I want to keep this file aimed at users as its audience (not us maintainers), but I think I found a way to clarify the comment that helps the users, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all discussions resolved, LGTM from assignee SeanCurtis-TRI (waiting on @jwnimmer-tri)
See also RobotLocomotion/drake#22197 for related changes.
This change is