Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use rollup bazel targets for drake docs #122

Merged
merged 2 commits into from
Jan 28, 2021
Merged

Use rollup bazel targets for drake docs #122

merged 2 commits into from
Jan 28, 2021

Conversation

jwnimmer-tri
Copy link
Contributor

@jwnimmer-tri jwnimmer-tri commented Jan 27, 2021 •
edited
Loading

@jwnimmer-tri
Use rollup bazel targets for doc test integration
420b5a1 
This insulates us from the minutiae of Drake's BUILD files.
@jwnimmer-tri jwnimmer-tri mentioned this pull request Jan 27, 2021
Merged
@jwnimmer-tri
Use doc:build rollup target for doc building
bb7b558 
This grants control of Drake's website layout to the Drake tree,
instead of the CI tree.
@jwnimmer-tri jwnimmer-tri changed the title Use rollup bazel targets for doc test integration Use rollup bazel targets for drake docs Jan 27, 2021
@jwnimmer-tri jwnimmer-tri mentioned this pull request Jan 27, 2021
Merged
@jwnimmer-tri
Copy link
Contributor Author

+@jamiesnape for review, please.

@jamiesnape
Copy link
Contributor

Can you push a copy of this to a branch of this repo (you should have permission) so I can test it?

@jwnimmer-tri
Copy link
Contributor Author

Sure -- https://github.com/RobotLocomotion/drake-ci/tree/doc-test should be it.

@jamiesnape
Copy link
Contributor

https://drake-jenkins.csail.mit.edu/job/linux-bionic-unprovisioned-gcc-bazel-experimental-documentation/21/

jamiesnape
jamiesnape approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@jamiesnape jamiesnape left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the doxygen_scratch were not a subdirectory of share/doc/drake (i.e., the directory pushed to GitHub Pages) it would make me a little more comfortable, but I guess that has always been the case, and I just did not notice.

@jamiesnape
Copy link
Contributor

I will let you merge, since I am not sure if you want to squash the commits (I have no preference).

@jwnimmer-tri
Copy link
Contributor Author

Don't mind much either way, but I'll keep them separate in case of needing a revert later on.

@jwnimmer-tri jwnimmer-tri merged commit 0e2e7e6 into RobotLocomotion:master Jan 28, 2021
@jwnimmer-tri jwnimmer-tri deleted the doc-test branch January 28, 2021 21:42
@jwnimmer-tri
Copy link
Contributor Author

If the doxygen_scratch were not a subdirectory of share/doc/drake (i.e., the directory pushed to GitHub Pages) it would make me a little more comfortable, but I guess that has always been the case, and I just did not notice.

I agree. (To be precise, I might have made it a little worse with this PR.) Anyway, that's the kind of thing I want to improve in Drake now that we have a more direct point of entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamiesnape jamiesnape jamiesnape approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jwnimmer-tri @jamiesnape