[drake_bazel_external] Adjust environ.bzl for Bazel 7 compatibility #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+@ggould-tri for both reviews per schedule, please. You'll note that CI is still failing with Bazel 7. There is also a Drake upstream bug preventing Bazel 7 from working. Notable here is that the nightly build error on drake-external-examples main (complaining about |
ggould-tri
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all discussions resolved, platform LGTM from [ggould-tri] (waiting on @jwnimmer-tri)
|
I'm going to need to do extra test jobs no matter what, so I guess I'll user my admin bits to force-merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is