Update CMake python use for drake_cmake_external #296
Conversation
There was a problem hiding this comment.
+@BetsyMcPhail for review
Reviewable status: all discussions resolved, LGTM missing from assignee betsymcphail, platform LGTM missing (waiting on @BetsyMcPhail)
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status: 1 unresolved discussion, LGTM missing from assignee betsymcphail, platform LGTM missing (waiting on @nicolecheetham)
drake_cmake_external/CMakeLists.txt line 27 at r1 (raw file):
list(APPEND CMAKE_PREFIX_PATH "${CMAKE_INSTALL_PREFIX}") if(APPLE)
BTW From here down to find_package(Python3 ... sets variables that are no longer used and can be removed?
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, platform LGTM from [betsymcphail] (waiting on @nicolecheetham)
There was a problem hiding this comment.
+@xuchenhan-tri for platform review
Reviewable status: 1 unresolved discussion, LGTM missing from assignee xuchenhan-tri, platform LGTM from [betsymcphail] (waiting on @BetsyMcPhail and @xuchenhan-tri)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all discussions resolved, LGTM missing from assignee xuchenhan-tri, platform LGTM from [betsymcphail] (waiting on @xuchenhan-tri)
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all discussions resolved, platform LGTM from [betsymcphail, xuchenhan-tri] (waiting on @nicolecheetham)
There was a problem hiding this comment.
Reviewable status:
Update CMakeLists.txt use of finding the python package and the python executable
Issue: RobotLocomotion/drake#21099
This change is