Move meshes and models from drake to drake_models #23
Conversation
Copied from Drake git sha 3f9800b1ebcd451e6042b3c5b302ebe3ba182061.
|
+@rpoyner-tri for feature review, please to match up with RobotLocomotion/drake#19160. |
There was a problem hiding this comment.
I verified that (almost) all of the files that came from drake were copied without changes, and the few that were changed only had internal file paths updated.
Reviewed 316 of 316 files at r1, all commit messages.
Reviewable status: 1 unresolved discussion, platform LGTM from [rpoyner-tri] (waiting on @jwnimmer-tri)
a discussion (no related file):
Do the conversion script files need more documentation? I assume they are not needed to be used, but rather are a record of the derivation of some of the files.
There was a problem hiding this comment.
Reviewable status: 1 unresolved discussion, platform LGTM from [rpoyner-tri] (waiting on @rpoyner-tri)
a discussion (no related file):
Previously, rpoyner-tri (Rick Poyner (rico)) wrote…
Do the conversion script files need more documentation? I assume they are not needed to be used, but rather are a record of the derivation of some of the files.
I think you're talking about some of the Atlas files. Is that right?
I think only moved those without any edits. If I made them worse (e.g., filenames are wrong now) then let me know and I should fix that here.
If your observation is that some old pre-TRI stuff from 2014 no longer meets our standards, I would agree but I don't think that's relevant to this PR.
There was a problem hiding this comment.
Reviewable status:
complete! all discussions resolved, platform LGTM from [rpoyner-tri] (waiting on @jwnimmer-tri)
a discussion (no related file):
Previously, jwnimmer-tri (Jeremy Nimmer) wrote…
I think you're talking about some of the Atlas files. Is that right?
I think only moved those without any edits. If I made them worse (e.g., filenames are wrong now) then let me know and I should fix that here.
If your observation is that some old pre-TRI stuff from 2014 no longer meets our standards, I would agree but I don't think that's relevant to this PR.
fair.
Towards RobotLocomotion/drake#19078 and RobotLocomotion/drake#11913.
See RobotLocomotion/drake#19160 for the sibling pull request.
This change is