Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eigen] Test overloads for dense vs. sparse #68

Conversation

EricCousineau-TRI
Copy link
Collaborator

@EricCousineau-TRI EricCousineau-TRI commented Nov 10, 2023

Towards RobotLocomotion/drake#20516

Attempting to encode the following test into pybind11 proper:
https://github.com/RobotLocomotion/drake/blob/77c2e56d825207e51c26bf7961d269a09af3f924/tmp/cc_py_test.py


This change is Reviewable

@EricCousineau-TRI
Copy link
Collaborator Author

EricCousineau-TRI commented Nov 10, 2023

FYI @jwnimmer-tri

But, uh, I can't get the same results as the Drake version... In Drake, it fails with the MyScalar spelling. Here, it does not.

Example build:

cd pybind11
cmake -S . -B build -DDOWNLOAD_CATCH=ON -DDOWNLOAD_EIGEN=ON -DPYBIND11_TEST_OVERRIDE=test_eigen_matrix
env PYTEST_ADDOPTS="--capture=no -k test_eigen_dense_sparse_overload" cmake --build build --target pytest -j

@EricCousineau-TRI
Copy link
Collaborator Author

Closed per #69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant