-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vive teleop #351
base: master
Are you sure you want to change the base?
Vive teleop #351
Conversation
Can one of the admins verify this patch? |
Jenkins please test (added to whitelist) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Two nits, but if it passes CI I'm happy with it!
(The Vive teleop script could certainly use cleaning up, but that's the same for the hydra and gamepad teleop scripts, so I'm OK leaving that for some future refactoring.)
I'd like to take a look at this before it gets merged, just to make sure it isn't messing up any core code. Should be able to get to it tonight. |
…lease and press move button again for safety)
…lease and press move button again for safety) Conflicts: scripts/bin/vive_teleop.py
Hey @jmcculloch2018 and @gizatt , would we like to merge this sometime soon? Looks like some very useful stuff in here, for example I just cherry-picked this commit: 8f0bf6f |
added dynamic instances, fixed issue with ascii export
Created script for controlling robot using vive
Made changes to procman config and docker_run to make teleop easier to run
Updated documentation
This change is