Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unable to open some attachments with SSL Client Certificate enabled #6130

Merged
merged 12 commits into from
Feb 12, 2025

Conversation

OtavioStasiak
Copy link
Contributor

@OtavioStasiak OtavioStasiak commented Feb 8, 2025

Proposed changes

Added ssl pinning logic to expo-file-system

Issue(s)

https://rocketchat.atlassian.net/browse/NATIVE-777

How to test or reproduce

  • It should be possible to open attachments on workspaces with SSL Client Certificate enabled

Known issue: avatars aren't loading on Android.

Screenshots

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@diegolmello diegolmello marked this pull request as ready for review February 11, 2025 16:09
@diegolmello diegolmello changed the title Fix certificate attachment issue fix: unable to open some attachments with SSL Client Certificate enabled Feb 11, 2025
@diegolmello diegolmello force-pushed the fix-certificate-attachment-issue branch from 4d39f3c to 5479660 Compare February 11, 2025 17:52
@diegolmello diegolmello force-pushed the fix-certificate-attachment-issue branch from 5479660 to e92f270 Compare February 11, 2025 17:54
@diegolmello diegolmello merged commit 1ad5e06 into develop Feb 12, 2025
13 of 18 checks passed
@diegolmello diegolmello deleted the fix-certificate-attachment-issue branch February 12, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants