Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: auto translate not working #6134

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

diegolmello
Copy link
Member

@diegolmello diegolmello commented Feb 14, 2025

Proposed changes

Regression introduced on #6080

Issue(s)

How to test or reproduce

Screenshots

Before After
Screenshot 2025-02-14 at 16 37 08 Screenshot 2025-02-14 at 16 37 20

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves a current function)
  • New feature (non-breaking change which adds functionality)
  • Documentation update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if applicable)
  • I have added necessary documentation (if applicable)
  • Any dependent changes have been merged and published in downstream modules

Further comments

NATIVE-790

@diegolmello diegolmello marked this pull request as ready for review February 14, 2025 19:44
Copy link
Contributor

@OtavioStasiak OtavioStasiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, it works as expected.

@diegolmello diegolmello merged commit c9b474f into develop Feb 14, 2025
3 of 8 checks passed
@diegolmello diegolmello deleted the regression.auto-translate branch February 14, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants