regression: Do not throw an error when a required custom field is missing on visitor to contact migration

[matheusbsilva137]

Proposed changes (including videos or screenshots)

Introduced here: #32727

• Skip custom fields validation on contact migration (since it has already been applied when mapping a visitor to a contact). Keeping this validation causes RC to throw an error in case the legacy visitor doesn't contain a field that is now required (which is unintended for this specific flow).

Issue(s)

Steps to test or reproduce

Further comments

On visitor to contact migration, we shouldn't throw errors in any of these cases:

• A custom field has been made required after updating to 7.1;
• A custom field has been removed after updating to 7.1;

#34030 has only partially fixed this issue (the second item has been addressed, but not the first one). In order to not throw errors on visitor to contact migration, we should skip the whole repeated validation process so that missing required fields do not generate an error.

SCI-179

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: cf14131

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34071/
on branch gh-pages at 2024-11-27 22:59 UTC

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.75%. Comparing base (fad7de4) to head (cf14131).
Report is 1 commits behind head on release-7.1.0.

Additional details and impacted files

@@              Coverage Diff               @@
##           release-7.1.0   #34071   +/-   ##
==============================================
  Coverage          75.75%   75.75%           
==============================================
  Files                510      510           
  Lines              22078    22078           
  Branches            5387     5387           
==============================================
  Hits               16726    16726           
  Misses              4706     4706           
  Partials             646      646           

Flag	Coverage Δ
unit	75.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.