-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
regression: old omnichannel rooms only being migrated after their data is loaded by the client #34090
base: release-7.1.0
Are you sure you want to change the base?
regression: old omnichannel rooms only being migrated after their data is loaded by the client #34090
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-7.1.0 #34090 +/- ##
==============================================
Coverage 75.75% 75.75%
==============================================
Files 510 510
Lines 22078 22078
Branches 5387 5387
==============================================
Hits 16726 16726
Misses 4706 4706
Partials 646 646
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
…a is loaded by the client, causing it to not have the ContactId available
70e4f6f
to
ac9e63c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if ci happy me happy
Proposed changes (including videos or screenshots)
Issue(s)
Steps to test or reproduce
Further comments
SCI-190
We no longer use
contacts.get
using the visitor association as parameter, only using the contactId; Since this endpoint was introduced on this same release, we've removed the option of using the visitor altogether with no risk of breaking anything.