regression: undefined fileBuffer in getUploadFormData when onFile is called before onField

[abhinavkrin]

Proposed changes (including videos or screenshots)

This PR addresses a regression in the getUploadFormData function where field events are processed after file events, causing the file buffer to become undefined. This leads to intermittent request failures when processing uploads.

Issue(s)

Steps to test or reproduce

Further comments

CORE-843

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: 0353ef8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34091/
on branch gh-pages at 2024-11-29 19:08 UTC

[codecov]

Codecov Report

Attention: Patch coverage is 90.47619% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.79%. Comparing base (5b4ed31) to head (0353ef8).

Additional details and impacted files

@@                Coverage Diff                @@
##           release-7.1.0   #34091      +/-   ##
=================================================
+ Coverage          75.75%   75.79%   +0.03%     
=================================================
  Files                510      512       +2     
  Lines              22078    22169      +91     
  Branches            5387     5397      +10     
=================================================
+ Hits               16726    16803      +77     
- Misses              4706     4713       +7     
- Partials             646      653       +7     

Flag	Coverage Δ
unit	75.79% <90.47%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[KevLehman]

can you add cases for:

• file uploaded & fileOptional true
• file uploaded with many extra fields