implement semver comparison for winget version detection #816
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
SemVer version comparison
Switch to actual SemVer version comparison for the available / installed version detection.
WinGet distributes "-preview" versions for participants of the insider program which currently isn't supported by the version comparison. This causes WAU to fully download and install an older WinGet version on every run even though the preview version is actually newer.
replace
Replace
withTrimStart
v1.10.40-preview
was currently detected as1.10.40-preiew
due toReplace("v", "")
.TrimStart("v")
fixes this.