Skip to content

Commit

Permalink
Merge pull request openSUSE#158 from Atul9/performance_hash_rubocop
Browse files Browse the repository at this point in the history
Solve Performance/HashEachMethods RuboCop cop offenses
  • Loading branch information
Ana06 authored Feb 21, 2018
2 parents 37b6ccf + 255264e commit c7936ec
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 10 deletions.
8 changes: 0 additions & 8 deletions .rubocop_todo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -301,14 +301,6 @@ Naming/UncommunicativeMethodArgName:
- 'lib/scrum/sprint_board.rb'
- 'lib/scrum/sprint_planning_board.rb'

# Offense count: 2
# Cop supports --auto-correct.
# Configuration parameters: AutoCorrect.
Performance/HashEachMethods:
Exclude:
- 'lib/cli.rb'
- 'lib/scrum/creator.rb'

# Offense count: 1
# Cop supports --auto-correct.
Security/YAMLLoad:
Expand Down
2 changes: 1 addition & 1 deletion lib/cli.rb
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ def get_checklists
def burndowns
process_global_options options
board_list = YAML.load_file(options['board-list'])
board_list.keys.each do |name|
board_list.each_key do |name|
raise 'invalid character in team name' if name =~ /[^[:alnum:]. _]/ # sanitize
board = board_list[name]
if options['output']
Expand Down
2 changes: 1 addition & 1 deletion lib/scrum/creator.rb
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ def create
private

def create_labels(board_id)
@scrum.label_names.each { |_, name| Trello::Label.create(name: name, board_id: board_id) }
@scrum.label_names.each_value { |name| Trello::Label.create(name: name, board_id: board_id) }
end

def create_sprint_board
Expand Down

0 comments on commit c7936ec

Please sign in to comment.