Skip to content

Commit

Permalink
fix: call highlighter and hinter from global table (closes #289)
Browse files Browse the repository at this point in the history
  • Loading branch information
TorchedSammy committed Apr 19, 2024
1 parent 40c3cec commit 16b39fe
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 10 deletions.
11 changes: 10 additions & 1 deletion api.go
Original file line number Diff line number Diff line change
Expand Up @@ -712,5 +712,14 @@ func hlhinter(t *rt.Thread, c *rt.GoCont) (rt.Cont, error) {
// #example
// #param line string
func hlhighlighter(t *rt.Thread, c *rt.GoCont) (rt.Cont, error) {
return c.Next(), nil
if err := c.Check1Arg(); err != nil {
return nil, err
}

line, err := c.StringArg(0)
if err != nil {
return nil, err
}

return c.PushingNext1(t.Runtime, rt.StringValue(line)), nil
}
13 changes: 4 additions & 9 deletions rl.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,8 @@ func newLineReader(prompt string, noHist bool) *lineReader {
hooks.Emit("hilbish.vimAction", actionStr, args)
}
rl.HintText = func(line []rune, pos int) []rune {
if hinter == nil {
return []rune{}
}

retVal, err := rt.Call1(l.MainThread(), rt.FunctionValue(hinter),
hinter := hshMod.Get(rt.StringValue("hinter"))
retVal, err := rt.Call1(l.MainThread(), hinter,
rt.StringValue(string(line)), rt.IntValue(int64(pos)))
if err != nil {
fmt.Println(err)
Expand All @@ -89,10 +86,8 @@ func newLineReader(prompt string, noHist bool) *lineReader {
return []rune(hintText)
}
rl.SyntaxHighlighter = func(line []rune) string {
if highlighter == nil {
return string(line)
}
retVal, err := rt.Call1(l.MainThread(), rt.FunctionValue(highlighter),
highlighter := hshMod.Get(rt.StringValue("highlighter"))
retVal, err := rt.Call1(l.MainThread(), highlighter,
rt.StringValue(string(line)))
if err != nil {
fmt.Println(err)
Expand Down

0 comments on commit 16b39fe

Please sign in to comment.