Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Lunacolors.md #331

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Improve Lunacolors.md #331

wants to merge 2 commits into from

Conversation

Naadiyaar
Copy link


  • I have reviewed CONTRIBUTING.md.
  • My commits and title use the Conventional Commit format.
  • I have documented changes and additions in the CHANGELOG.md.

Improved document formatting and mentioned 2 Lunacolors styles; reset and bright backgrounds.

@@ -28,14 +28,17 @@ Colors:
- magenta
- cyan
- white

Styles:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Styles:
Styles:

For the colors, there are background and bright variants. Background color
variants have a `Bg` suffix, while bright variants use the `bright` prefix.
These can also be combined. Note that appropriate camel casing must be applied.
For example, bright blue would be written as `brightBlue`, a cyan background as
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For example, bright blue would be written as `brightBlue`, a cyan background as
For example, bright blue would be written as `brightBlue`, a cyan background as

blue would be `brightBlue` and background cyan would be `cyanBg`.
For the colors, there are background and bright variants. Background color
variants have a `Bg` suffix, while bright variants use the `bright` prefix.
These can also be combined. Note that appropriate camel casing must be applied.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
These can also be combined. Note that appropriate camel casing must be applied.
These can also be combined. Note that appropriate camel casing must be applied.

Copy link
Member

@TorchedSammy TorchedSammy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small markdown changes. make sure to actually read the contributing.md and make your commits conventional and PR title.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants