Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove sh dependence in core hilbish code (and add snail library - for shell script) #337

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

TorchedSammy
Copy link
Member

@TorchedSammy TorchedSammy commented Dec 29, 2024

the hilbish website basically states shell script as being as something disgusting (which it kind of is) but a good part of the go core of hilbish is dependent on specific, odd behavior of the shell script interpreter (because hilbish still does use shell script for interactive code, and lua as well).

code changes in the fs module had to be made so the cd command would also change the working directory of the shell interpreter. i'm kinda annoyed of that, and also, i want to be able to do a few things:

  1. reduce go code and add more lua
    • while moving the shell script code from a library wont remove the go code, it can reduce it and also add more lua code :]
  2. make more of the shell script functions and utils useable via lua

this pr introduces the snail library to provide functions to use the hilbish provided shell script interpreter library via lua. this would be the same as the sh runner. i can also clean up some hilbish exec code this way.

depends on #335

@TorchedSammy TorchedSammy changed the title refactor: decouple sh dependence in hilbish (and add snail library - for shell script) refactor: decouple sh dependence in core hilbish code (and add snail library - for shell script) Dec 29, 2024
@TorchedSammy TorchedSammy changed the title refactor: decouple sh dependence in core hilbish code (and add snail library - for shell script) refactor: remove sh dependence in core hilbish code (and add snail library - for shell script) Dec 29, 2024
@TorchedSammy TorchedSammy added this to the v2.4 (Moonflower) milestone Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant