fix: make order tracking more robust. #96
Conversation
| @@ -29,34 +45,35 @@ def __init__( | |||
| self.open = open | |||
|
|
|||
| @staticmethod | |||
| def get_fields(offer_query: Any) -> List: | |||
| def get_fields(field_paths: Dict[str, FieldPath]) -> List: | |||
There was a problem hiding this comment.
with how we are initializing the Offer/Trade entities in _initialize_subgraph_trade for example, we will most likely want the fields that are returned to have the option to not include the added synthetic fields.
| return offers_query | ||
| block_field_path = self.subgraph.Query._meta().block() # noqa | ||
|
|
||
| return {"offer": offers_field_path, "block": block_field_path} | ||
|
|
||
| def _build_trades_query( |
There was a problem hiding this comment.
i think it makes sense to also update the way we retrieve trades to match what we are doing with offers in this PR, it seems like a better approach going forward
| @@ -88,19 +88,36 @@ def __init__( | |||
| # inventory functions | |||
| ###################################################################### | |||
|
|
|||
| def update_fair_price(self, fair_price: Decimal): | |||
There was a problem hiding this comment.
it may be helpful to have the ability to return back whatever the difference between the existing grid and the new grid is. however, without tracking what existing offers there are on the market this may not be all that helpful within the Grid class itself.
|
|
||
| while polling: | ||
| while self.running_event_pollers[event_poller_name] == from_block: | ||
| try: | ||
| for event_data in event_filter.get_new_entries(): |
Make order tracking more robust.
Description
This PR aims to make order tracking more robust by changing the following:
block_numberfor queries to get_offers from the Subgraph.on_subgrounds_order_queryto the gridbot to update inventory accordingly.from_blockto thestart_event_pollermethod so we can create filters from a specific block number.stop_event_pollermethod so we can also stop old event pollers.What was the issue?
The order tracking client would sometimes miss orders. This introduces a periodic poll to the subgraph to ensure all orders are correct.
What type of change was this