Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI #38

Merged
merged 4 commits into from
Jan 21, 2025
Merged

Update CI #38

merged 4 commits into from
Jan 21, 2025

Conversation

n-rodriguez
Copy link
Contributor

Thank you!

@tarcieri tarcieri merged commit 0f3bb43 into RubyCrypto:main Jan 21, 2025
@n-rodriguez
Copy link
Contributor Author

Thank you!

@n-rodriguez n-rodriguez deleted the wip/ci branch January 21, 2025 19:01
@tarcieri
Copy link
Contributor

@n-rodriguez it looks like RuboCop is (unrelatedly) failing, FWIW

@n-rodriguez
Copy link
Contributor Author

@tarcieri yes, it's due to Gemspec/RequireMFA: metadata['rubygems_mfa_required'] must be set to 'true'.

I don't know what you want to do with that :) (you must enable MFA on Rubygems first)

@tarcieri
Copy link
Contributor

tarcieri commented Jan 21, 2025

It can be added to the code first, right? Nothing is actually linting it against RubyGems?

Or you can shut off that cop

@n-rodriguez
Copy link
Contributor Author

It can be added to the code first, right? Nothing is actually linting it against RubyGems?

Yes but :

The version being released with rubygems_mfa_required set and all the following versions will require you to have MFA enabled.

See: https://guides.rubygems.org/mfa-requirement-opt-in/

Or you can shut off that cop

I can do that

@n-rodriguez
Copy link
Contributor Author

@tarcieri Fixed in #39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants