Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fibbonachi heap #2

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fibbonachi heap #2

wants to merge 5 commits into from

Conversation

RunFMe
Copy link
Owner

@RunFMe RunFMe commented Nov 25, 2018

No description provided.

@RunFMe RunFMe requested a review from rationalex November 25, 2018 17:42
#include <memory>
#include <cassert>
template <class T>
class FibbonachiHeap {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fibonacci

#include <stdexcept>
#include <memory>
#include <cassert>
template <class T>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Пустая строка между #include'ами и объявлением класса.

unsigned long size_;
TreeNode* min_root;

void static concat_node_lists(TreeNode* &first_list, TreeNode* second_list) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ааа сокращения в названиях функций. Зачем экономить символы, мы не ядро линукса и не микропроцессоры пишем, где каждый байт на счету.

}
}

unsigned long D() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Что делает эта функция? Совершенно непонятно из названия.

public:
T value;
bool mark;
TreeNode* left_sib;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Сделай shared_ptr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants