Skip to content

Commit

Permalink
Skip render_gltf_client tests that fail on macOS (RobotLocomotion#19306)
Browse files Browse the repository at this point in the history
  • Loading branch information
liangfok authored Apr 28, 2023
1 parent 38ecfa7 commit 4cc4dce
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions geometry/render_gltf_client/test/integration_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,11 @@
LABEL_PIXEL_THRESHOLD = 0
INVALID_PIXEL_FRACTION = 0.2

# TODO(#19305) Remove this once the skipped tests reliably pass on macOS.
_SKIP = False
if "darwin" in sys.platform:
_SKIP = True


class TestIntegration(unittest.TestCase):
def setUp(self):
Expand Down Expand Up @@ -215,6 +220,7 @@ def _check_one_gltf(self, gltf, ground_truth_gltf):
# normalization, e.g., meshes, cameras, materials, accessors, etc.
self.assertCountEqual(actual["nodes"], expected["nodes"])

@unittest.skipIf(_SKIP, "Skipped on macOS, see #19305")
def test_integration(self):
"""Quantitatively compares the images rendered by RenderEngineVtk and
RenderEngineGltfClient via a fully exercised RPC pipeline.
Expand Down Expand Up @@ -260,6 +266,7 @@ def test_integration(self):
)
self.assert_error_fraction_less(label_diff, INVALID_PIXEL_FRACTION)

@unittest.skipIf(_SKIP, "Skipped on macOS, see #19305")
def test_gltf_conversion(self):
"""Checks that the fundamental structure of the generated glTF files is
preserved. The comparison of the exact texture information is not in
Expand Down

0 comments on commit 4cc4dce

Please sign in to comment.