Use visible_by_default to hide collision geometry #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MeshcatVisualizer itself owns the `path` its publishing to; calling meshcat.SetProperty for visibility no longer works.
|
Note that I created this by hand-editing the JSON. I was hoping there was CI here to double-check me, but I don't see it yet. You might want to test locally before merging, or just after with a fix-forward. |
|
Oops, I didn't mention in the issue in the Drake repo that I had created a PR for this fix (#238). Looks like our code logic is the same, so either PR should work. |
RussTedrake
approved these changes
Jun 30, 2023
There was a problem hiding this comment.
You guys are both awesome! I'll take this version just to avoid the minor thrashing in the ipynb metadata.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jwnimmer-tri)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MeshcatVisualizer itself owns the
pathits publishing to; calling meshcat.SetProperty for visibility no longer works.See RobotLocomotion/drake#19702.
This change is