Use global static Regex variable for pattern matching
#10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CohenArthur
reviewed
Aug 14, 2024
There was a problem hiding this comment.
I reviewed the commits not present in #6 and it's really good! well done! can't wait to try it out haha
CohenArthur
approved these changes
Aug 14, 2024
MahadMuhammad
force-pushed
the
feat/static-regex
branch
from
3e765b6 to
e80c416
Compare
Merged
CohenArthur
approved these changes
Aug 19, 2024
|
there are conflicts atm since I rebased and merged #6, once those are fixed we can merge that one too |
Signed-off-by: Muhammad Mahad <[email protected]>
Add `regex` and exported it for other files Signed-off-by: Muhammad Mahad <[email protected]>
Signed-off-by: Muhammad Mahad <[email protected]>
Fixes: Rust-GCC#9 Signed-off-by: Muhammad Mahad <[email protected]>
Signed-off-by: Muhammad Mahad <[email protected]>
Signed-off-by: Muhammad Mahad <[email protected]>
MahadMuhammad
force-pushed
the
feat/static-regex
branch
from
e80c416 to
b4fa7a1
Compare
|
Rebased and ready to merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
regex!macro for convenient pattern matchingerror codeifsourcefile has uncomplete error msg #9rustcdirectives and converting todejagnudirective with relative line numbers #6