Add logic for CursorEntered/CursorLeft on x11 #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbert-vdh
requested changes
Oct 7, 2023
Comment on lines
+617
to
+620
| handler.on_event( | ||
| &mut crate::Window::new(self), | ||
| Event::Mouse(MouseEvent::CursorEntered), | ||
| ); |
There was a problem hiding this comment.
This should also generate CursorMoved event. From the spec:
If pointer motion or window hierarchy change causes the pointer to be in a different window than before,
EnterNotifyandLeaveNotifyevents are generated instead of aMotionNotifyevent.
There was a problem hiding this comment.
Good catch! Added. As far as I can tell, EnterNotifyEvent's detail or mode shouldn't matter for that, so it should be right.
edit: I don't currently have a Linux machine so I can't test if the change is working as it should. I can test on tuesday if you can't
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary to fix vizia/vizia#407, which is a bug that locks up the GUI when you press down on a mouse button inside the window and release the button outside the window.