Remove RawWindowHandleWrapper #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahrj
force-pushed
the
gl-raw-window-handle
branch
from
066b989 to
5edb461
Compare
Engid
reviewed
Dec 12, 2023
| @@ -21,12 +21,6 @@ pub struct WindowHandle { | |||
| phantom: PhantomData<*mut ()>, | |||
| } | |||
|
|
|||
| /// Quick wrapper to satisfy [HasRawWindowHandle], because of course a raw window handle wouldn't | |||
There was a problem hiding this comment.
sad to see this comment go 😆
RawWindowHandleWrapper is only necessary since GlContext::create takes an `impl HasRawWindowHandle` argument, but GlContext::create is an internal unsafe API and it is can just take a RawWindowHandle directly.
micahrj
force-pushed
the
gl-raw-window-handle
branch
from
5edb461 to
4b7bf6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RawWindowHandleWrapper is only necessary since GlContext::create takes an
impl HasRawWindowHandleargument, but GlContext::create is an internal unsafe API and it can just take a RawWindowHandle directly.