Handle set_mouse_cursor event on windows #186
Conversation
Fredemus
force-pushed
the
windows-set-cursor
branch
from
57dd7ec to
a328b4c
Compare
Fredemus
force-pushed
the
windows-set-cursor
branch
from
a328b4c to
7b926c9
Compare
src/win/cursor.rs
Outdated
| MouseCursor::Help => IDC_HELP, | ||
|
|
||
| // hiding cursor can't be turned into an lpcwstr since it's done by ShowCursor instead of SetCursor | ||
| MouseCursor::Hidden => IDC_ARROW, |
There was a problem hiding this comment.
The docs for SetCursor state that passing NULL hides the cursor, so I think returning ptr::null_mut() here would be more straightforward than using ShowCursor.
There was a problem hiding this comment.
Huh I missed that. I don't really get the point of ShowCursor then. Fixed
There was a problem hiding this comment.
It's just an alternative API that works slightly differently. I think all of Windows, macOS, and X11 have both a "show/hide cursor" API and a way to set the cursor to an empty image. The latter is just a closer fit for Baseview's API, since it treats "hidden" as one of the possible cursor states rather than having separate methods for showing and hiding the cursor.
src/win/cursor.rs
Outdated
| MouseCursor::Help => IDC_HELP, | ||
|
|
||
| // hiding cursor can't be turned into an lpcwstr since it's done by ShowCursor instead of SetCursor | ||
| MouseCursor::Hidden => IDC_ARROW, |
There was a problem hiding this comment.
Huh I missed that. I don't really get the point of ShowCursor then. Fixed
This adds the ability to change the cursor on Windows platforms. For some reason there are very few default cursors included in Windows so a lot of cursors available on other platforms aren't available yet, which is why many of the
MouseCursoroptions just maps toIDC_ARROW. I'll look into adding custom cursors next.LoadCursorWis supposedly superseded by LoadImageW but I couldn't find a way to do it with that one that doesn't crash.Tested with Vizia's cursor icon example here and everything seems to work as it should.
Also tested by hovering over some buttons on a plugin.