ssh-key: Add Certificate::decode_as and expose KeyData::decode_as
#233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
This additional function is needed for SSH Agent Protocol where, based on the algorithm, we need to parse the `Certificate` or the `KeyData`. Without `decode_as` the `decode` function will greedily consume additional string from the reader. See: wiktor-k/ssh-agent-lib#83 Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
wiktor-k
added a commit
to wiktor-k/ssh-agent-lib
that referenced
this pull request
Jul 9, 2024
See: RustCrypto/SSH#233 Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
tarcieri
approved these changes
Jul 10, 2024
|
Hi @tarcieri, sorry to disturb but I'm wondering if you're planning on releasing Thanks for your time! |
|
Sure, I can cut some prereleases, although I'll need to cut prereleases of the dependencies first (which is something I planned on doing soon anyway) |
|
That's great to hear. Thanks! 🙇♂️ |
|
If you don't mind I'll ping you every now and then @tarcieri 👋 |
|
It might be awhile. There are dozens upon dozens of downstream dependencies to do prereleases of. |
|
Release PR here: #250 I had to temporarily remove the |
|
Thank you 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This additional function is needed for SSH Agent Protocol where, based on
the algorithm, we need to parse the
Certificateor theKeyData.Without
decode_asthedecodefunction will greedily consume additionalstring from the reader.
This is similar to #211.
See: wiktor-k/ssh-agent-lib#83