Add benchmarks comparing random_mod and random_bits #703
+97
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tarcieri I noticed that generating random numbers using
random_mod
is slower than usingrandom_bits
repeatedly until the random number is below the given bound, like so:The benchmarks show that
random_mod
is ~4x slower thanrandom_bits
.It's not obvious to me why this is the case and perhaps it is to be expected. Is this something that is worth investigating further?