Define and use constants based on EF Core version, not dotnet one #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akridian
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EF Core 9 can be used with dotnet 8 (as we do in our projects). And I believe EF Core 8 is suitable for dotnet 9.
Current configuration leads to incorrect behaviour when
EntityFrameworkCore.UseRowNumberForPagingis used with dotnet 8 and EF Core 9.This PR introduces new properties and compilation constants. With them use can publish two version of the package: one for EF Core 8 and the other for EF Core 9.
According to docs
-Properties UseEfCore8=false -Properties UseEfCore9=trueshould do it. Just flip around boolean flags.I also made
Versionproperty dependant on those flags, but it is just a suggestion.