JIT Sparse SSBU fix #319
Merged
JIT Sparse SSBU fix #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cpu
Merged
LotP1
force-pushed
the
JIT-Sparse-SSBU-fix
branch
2 times, most recently
from
85e840f to
64cbc15
Compare
This reverts commit 9bc2cbf.
storing 36 bits of data in a 32 bit integer doesn't work so well
I forgot to include this change in the previous commit
Merged
GreemDev
pushed a commit
that referenced
this pull request
Dec 19, 2024
A couple of games have random crashing with the JIT Sparse Ftable changes, and it seems to have been caused by an insufficient int size returned by `AddressTableLevel#GetValue(ulong address)`. It was 32 bits (Int32), but the GiantBlock (which is the current address table impl) uses potentially 36 bits for the first level.
marco-carvalho
pushed a commit
to marco-carvalho/Ryujinx-1
that referenced
this pull request
Jan 5, 2025
A couple of games have random crashing with the JIT Sparse Ftable changes, and it seems to have been caused by an insufficient int size returned by `AddressTableLevel#GetValue(ulong address)`. It was 32 bits (Int32), but the GiantBlock (which is the current address table impl) uses potentially 36 bits for the first level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSBU randomly crashes with the JIT Sparse rewrite, this PR will attempt to fix this issue.