Typescript configuration for Fiori elements apps #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-kobo
changed the title
devinea
reviewed
Nov 26, 2024
There was a problem hiding this comment.
@c-kobo A few small comments to align with fiori tools generation of new projects.
I noticed a test failing here.
http://localhost:4004/sap.fe.cap.travel/test/integration/Opa.qunit.html
Co-authored-by: Austin Devine <[email protected]>
Co-authored-by: Austin Devine <[email protected]>
OPA tests should be fine again now. |
|
Jest tests still failing. |
|
@stewsk @chgeo the jest tests fail due to an incompability with cds-plugin-ui5. |
- Avoid log pollution from `cds-ui5-plugin` by using `deploy --out` param instead of capturing all stdout - Update Java pom: parent-less pom, cds-service 3.5.0
|
Look Ma, it's green 🥳 |
Akatuoro
added a commit
that referenced
this pull request
Dec 3, 2024
Disables the cds ui5 plugin for mocha tests, removing the need for the forceful mocha exit introduced with #1286 . --------- Co-authored-by: Christian Georgi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables typescript for both apps Travel Processor and Travel Analytics.
Additionally, for the Travel Processor App, the following flexible programming model based extensions are added:
Other changes
karma-ui5-transpileto get TS working in Karma testsapp/*/package=lock.jsonfileskarma.conffilesodata.test.jswhich also caused problems withts-jestnpm cicalls in pipelinedeploy -outparam in Maven build to not be disturbed by extra stdout ouput fromcds-ui5-plugin