Fixed AFF review comments.

SAP · Nov 5, 2024 · 3c452b4 · 3c452b4
1 parent e42a874
commit 3c452b4
Show file tree

Hide file tree

Showing 4 changed files with 61 additions and 61 deletions.
diff --git a/file-formats/ints/README.md b/file-formats/ints/README.md
@@ -2,4 +2,4 @@
 
 File | Cardinality | Definition | Schema | Example
 :--- | :--- | :--- | :--- | :---
-`<name>.ints.json` | 1 | [`zif_aff_ints_v1.intf.abap`](./type/zif_aff_ints_v1.intf.abap) | [`ints-v1.json`](./ints-v1.json) | [`rm_test_adt_959.ints.json`](./examples/rm_test_adt_959.ints.json)
+`<name>.ints.json` | 1 | [`zif_aff_ints_v1.intf.abap`](./type/zif_aff_ints_v1.intf.abap) | [`ints-v1.json`](./ints-v1.json) | [`rm_test_adt_965.ints.json`](./examples/rm_test_adt_965.ints.json)
diff --git a/...s/ints/examples/rm_test_adt_959.ints.json → ...s/ints/examples/rm_test_adt_965.ints.json b/...s/ints/examples/rm_test_adt_959.ints.json → ...s/ints/examples/rm_test_adt_965.ints.json
@@ -1,7 +1,7 @@
 {
   "formatVersion": "1",
   "header": {
-    "description": "ADT Test 959",
+    "description": "ADT Test 965",
     "originalLanguage": "en"
   },
   "intelligentScenario": {
@@ -16,8 +16,8 @@
     "oauthProfile": "ISLM_SAPGENAI_OAUTH_PRF_HCP"
   },
   "modellingContext": {
-    "name": "DEFAULT",
-    "modellingContextId": "0405E348470277F0EBDAEF4E3CEC2C31",
-    "description": "Default context"
+    "modellingContextName": "DEFAULT",
+    "modellingContextId": "6317387B9D71A70C6C9E025D46DC0066",
+    "modellingContextDescription": "Default context"
   }
 }
diff --git a/file-formats/ints/ints-v1.json b/file-formats/ints/ints-v1.json
@@ -80,7 +80,7 @@
         },
         "isDataManagementEnabled": {
           "title": "Data Management",
-          "description": "If true, the scenario uses Data Management",
+          "description": "If true, the scenario uses data management",
           "type": "boolean"
         },
         "isTurnkeyAutoSwitchOn": {
@@ -160,7 +160,7 @@
       "description": "Intelligent scenario modelling context",
       "type": "object",
       "properties": {
-        "name": {
+        "modellingContextName": {
           "title": "Modelling Context Name",
           "description": "Modelling context name",
           "type": "string",
@@ -172,9 +172,9 @@
           "type": "string",
           "maxLength": 36
         },
-        "description": {
-          "title": "Description",
-          "description": "Description",
+        "modellingContextDescription": {
+          "title": "Modelling Context Description",
+          "description": "Modelling context description",
           "type": "string",
           "maxLength": 100
         }
@@ -250,7 +250,7 @@
               "Avas"
             ],
             "enumDescriptions": [
-              "Table Function",
+              "Table function",
               "CDS view",
               "Class",
               "DCL",
@@ -272,14 +272,14 @@
         "description": "Scenario dataset binding",
         "type": "object",
         "properties": {
-          "name": {
+          "bindingName": {
             "title": "Binding Name",
             "description": "Name of the binding",
             "type": "string",
             "maxLength": 30
           },
-          "reference": {
-            "title": "Reference object",
+          "referenceObject": {
+            "title": "Reference Object",
             "description": "Reference object(for example - CDS view)",
             "type": "string",
             "maxLength": 36
@@ -297,7 +297,7 @@
         "description": "Scenario signature",
         "type": "object",
         "properties": {
-          "inputName": {
+          "signatureName": {
             "title": "Signature Name",
             "description": "Signature name",
             "type": "string",
@@ -309,7 +309,7 @@
             "type": "string",
             "maxLength": 32
           },
-          "description": {
+          "signatureDescription": {
             "title": "Description",
             "description": "Description",
             "type": "string",
@@ -322,7 +322,7 @@
             "maxLength": 30
           },
           "fieldPosition": {
-            "title": "Position",
+            "title": "Field Position",
             "description": "Position of the field",
             "type": "integer",
             "minimum": -2147483648,
@@ -334,7 +334,7 @@
             "type": "string",
             "maxLength": 100
           },
-          "fieldType": {
+          "fieldRole": {
             "title": "Role of Field",
             "description": "Role of field in an intelligent scenario (such as key, target)",
             "type": "string",
@@ -359,19 +359,19 @@
         "description": "Parameter signature",
         "type": "object",
         "properties": {
-          "name": {
+          "parameterName": {
             "title": "Parameter Name",
             "description": "Parameter name",
             "type": "string",
             "maxLength": 256
           },
-          "type": {
+          "parameterType": {
             "title": "Parameter Type",
             "description": "Parameter type",
             "type": "string",
             "maxLength": 32
           },
-          "description": {
+          "parameterDescription": {
             "title": "Parameter Description",
             "description": "Parameter description",
             "type": "string"
@@ -400,13 +400,13 @@
             "type": "string",
             "maxLength": 36
           },
-          "context": {
+          "parameterContext": {
             "title": "Parameter Context",
             "description": "Parameter context",
             "type": "string",
             "maxLength": 1000
           },
-          "value": {
+          "parameterValue": {
             "title": "Parameter Value",
             "description": "Parameter value",
             "type": "string"
@@ -425,7 +425,7 @@
         "type": "object",
         "properties": {
           "additionalInfoKey": {
-            "title": "Key",
+            "title": "Additional Info Key",
             "description": "Additional information key",
             "type": "string",
             "maxLength": 50
@@ -450,13 +450,13 @@
             "minimum": -2147483648,
             "maximum": 2147483647
           },
-          "keyLabel": {
+          "keyTextLabel": {
             "title": "Key Text Label",
             "description": "Additional information key text label",
             "type": "string",
             "maxLength": 255
           },
-          "valueLabel": {
+          "valueTextLabel": {
             "title": "Value Text Label",
             "description": "Additional information value text label",
             "type": "string",
@@ -482,8 +482,8 @@
             "maxLength": 30
           },
           "fieldPosition": {
-            "title": "Position",
-            "description": "Position",
+            "title": "Field Position",
+            "description": "Field position",
             "type": "integer",
             "minimum": -2147483648,
             "maximum": 2147483647

diff --git a/file-formats/ints/type/zif_aff_ints_v1.intf.abap b/file-formats/ints/type/zif_aff_ints_v1.intf.abap
@@ -29,7 +29,7 @@ INTERFACE zif_aff_ints_v1
   CONSTANTS:
     BEGIN OF co_logical_object_type,
       "! <p class="shorttext">Table Function</p>
-      "! Table Function
+      "! Table function
       table_function TYPE ty_logical_object_type VALUE 'F',
       "! <p class="shorttext">CDS View</p>
       "! CDS view
@@ -80,7 +80,7 @@ INTERFACE zif_aff_ints_v1
       "! If true, the scenario can have multiple active models
       is_multi_active_model      TYPE abap_bool,
       "! <p class="shorttext">Data Management</p>
-      "! If true, the scenario uses Data Management
+      "! If true, the scenario uses data management
       is_data_management_enabled TYPE abap_bool,
       "! <p class="shorttext">Automate Turnkey Switch On</p>
       "! If true, scenario will be turnkey enabled to automate the operations
@@ -122,91 +122,91 @@ INTERFACE zif_aff_ints_v1
     BEGIN OF ty_binding,
       "! <p class="shorttext">Binding Name</p>
       "! Name of the binding
-      name      TYPE zif_aff_types_v1=>ty_object_name_30,
-      "! <p class="shorttext">Reference object</p>
+      binding_name     TYPE zif_aff_types_v1=>ty_object_name_30,
+      "! <p class="shorttext">Reference Object</p>
       "! Reference object(for example - CDS view)
-      reference TYPE c LENGTH 36,
+      reference_object TYPE c LENGTH 36,
     END OF ty_binding,
 
     "! <p class="shorttext">Signature</p>
     "! Scenario signature
     BEGIN OF ty_signature,
       "! <p class="shorttext">Signature Name</p>
       "! Signature name
-      input_name           TYPE zif_aff_types_v1=>ty_object_name_30,
+      signature_name        TYPE zif_aff_types_v1=>ty_object_name_30,
       "! <p class="shorttext">Signature Type</p>
       "! Signature type
-      signature_type       TYPE c LENGTH 32,
+      signature_type        TYPE c LENGTH 32,
       "! <p class="shorttext">Description</p>
       "! Description
-      description          TYPE c LENGTH 100,
+      signature_description TYPE c LENGTH 100,
       "! <p class="shorttext">Field Name</p>
       "! Table or view field name
-      field_name           TYPE zif_aff_types_v1=>ty_object_name_30,
-      "! <p class="shorttext">Position</p>
+      field_name            TYPE zif_aff_types_v1=>ty_object_name_30,
+      "! <p class="shorttext">Field Position</p>
       "! Position of the field
-      field_position       TYPE i,
+      field_position        TYPE i,
       "! <p class="shorttext">Storage Type</p>
       "! Storage type of the field
-      storage_type         TYPE c LENGTH 100,
+      storage_type          TYPE c LENGTH 100,
       "! <p class="shorttext">Role of Field</p>
       "! Role of field in an intelligent scenario (such as key, target)
-      field_type           TYPE c LENGTH 30,
+      field_role            TYPE c LENGTH 30,
       "! <p class="shorttext">Data Management Type</p>
       "! Data management type
-      data_management_type TYPE zif_aff_types_v1=>ty_object_name_30,
+      data_management_type  TYPE zif_aff_types_v1=>ty_object_name_30,
     END OF ty_signature,
 
     "! <p class="shorttext">Modelling Context</p>
     "! Intelligent scenario modelling context
     BEGIN OF ty_modelling_context,
       "! <p class="shorttext">Modelling Context Name</p>
       "! Modelling context name
-      name                 TYPE zif_aff_types_v1=>ty_object_name_30,
+      modelling_context_name        TYPE zif_aff_types_v1=>ty_object_name_30,
       "! <p class="shorttext">Modelling Context ID</p>
       "! Modelling context ID
-      modelling_context_id TYPE c LENGTH 36,
-      "! <p class="shorttext">Description</p>
-      "! Description
-      description          TYPE c LENGTH 100,
+      modelling_context_id          TYPE c LENGTH 36,
+      "! <p class="shorttext">Modelling Context Description</p>
+      "! Modelling context description
+      modelling_context_description TYPE c LENGTH 100,
     END OF ty_modelling_context,
 
     "! <p class="shorttext">Parameter Signature</p>
     "! Parameter signature
     BEGIN OF ty_parameter,
       "! <p class="shorttext">Parameter Name</p>
       "! Parameter name
-      name           TYPE c LENGTH 256,
+      parameter_name        TYPE c LENGTH 256,
       "! <p class="shorttext">Parameter Type</p>
       "! Parameter type
-      type           TYPE c LENGTH 32,
+      parameter_type        TYPE c LENGTH 32,
       "! <p class="shorttext">Parameter Description</p>
       "! Parameter description
-      description    TYPE string,
+      parameter_description TYPE string,
       "! <p class="shorttext">Storage Type</p>
       "! Storage type
-      storage_type   TYPE c LENGTH 100,
+      storage_type          TYPE c LENGTH 100,
       "! <p class="shorttext">Context Flag</p>
       "! If true, then input context value is available
-      has_context    TYPE abap_bool,
+      has_context           TYPE abap_bool,
       "! <p class="shorttext">Parameter Size</p>
       "! Parameter size
-      parameter_size TYPE i,
+      parameter_size        TYPE i,
       "! <p class="shorttext">Parameter ID</p>
       "! Parameter ID
-      parameter_id   TYPE c LENGTH 36,
+      parameter_id          TYPE c LENGTH 36,
       "! <p class="shorttext">Parameter Context</p>
       "! Parameter context
-      context        TYPE c LENGTH 1000,
+      parameter_context     TYPE c LENGTH 1000,
       "! <p class="shorttext">Parameter Value</p>
       "! Parameter value
-      value          TYPE string,
+      parameter_value       TYPE string,
     END OF ty_parameter,
 
     "! <p class="shorttext">Additional Information</p>
     "! Additional information
     BEGIN OF ty_additional_info,
-      "! <p class="shorttext">Key</p>
+      "! <p class="shorttext">Additional Info Key</p>
       "! Additional information key
       additional_info_key TYPE c LENGTH 50,
       "! <p class="shorttext">Value ID</p>
@@ -220,10 +220,10 @@ INTERFACE zif_aff_ints_v1
       position_id         TYPE i,
       "! <p class="shorttext">Key Text Label</p>
       "! Additional information key text label
-      key_label           TYPE c LENGTH 255,
+      key_text_label      TYPE c LENGTH 255,
       "! <p class="shorttext">Value Text Label</p>
       "! Additional information value text label
-      value_label         TYPE c LENGTH 255,
+      value_text_label    TYPE c LENGTH 255,
     END OF ty_additional_info,
 
     "! <p class="shorttext">SBS Segment Field</p>
@@ -232,8 +232,8 @@ INTERFACE zif_aff_ints_v1
       "! <p class="shorttext">Field Name</p>
       "! Table or view field name
       field_name     TYPE c LENGTH 30,
-      "! <p class="shorttext">Position</p>
-      "! Position
+      "! <p class="shorttext">Field Position</p>
+      "! Field position
       field_position TYPE i,
       "! <p class="shorttext">Is Key Field</p>
       "! If true, the field is a key field