Fixed AFF review comments.

SAP · Nov 5, 2024 · ecca3a2 · ecca3a2
1 parent aacdc9f
commit ecca3a2
Show file tree

Hide file tree

Showing 4 changed files with 44 additions and 44 deletions.
diff --git a/file-formats/intm/README.md b/file-formats/intm/README.md
@@ -2,4 +2,4 @@
 
 File | Cardinality | Definition | Schema | Example
 :--- | :--- | :--- | :--- | :---
-`<name>.intm.json` | 1 | [`zif_aff_intm_v1.intf.abap`](./type/zif_aff_intm_v1.intf.abap) | [`intm-v1.json`](./intm-v1.json) | [`saplvfkd32izflkp5or2uqi1jlc4.intm.json`](./examples/saplvfkd32izflkp5or2uqi1jlc4.intm.json)
+`<name>.intm.json` | 1 | [`zif_aff_intm_v1.intf.abap`](./type/zif_aff_intm_v1.intf.abap) | [`intm-v1.json`](./intm-v1.json) | [`sapq0lic8p8o65ew6afk3aen3gp3.intm.json`](./examples/sapq0lic8p8o65ew6afk3aen3gp3.intm.json)
diff --git a/...es/saplvfkd32izflkp5or2uqi1jlc4.intm.json → ...es/sapq0lic8p8o65ew6afk3aen3gp3.intm.json b/...es/saplvfkd32izflkp5or2uqi1jlc4.intm.json → ...es/sapq0lic8p8o65ew6afk3aen3gp3.intm.json
@@ -4,29 +4,29 @@
     "description": "Model creation test via ADT",
     "originalLanguage": "en"
   },
-  "intelligentModel": {
-    "name": "RM_TEST_ADT_959_MOD",
-    "intelligentScenario": "RM_TEST_ADT_959",
-    "modellingContextId": "0405E348470277F0EBDAEF4E3CEC2C31",
+  "intelligentScenarioModel": {
+    "modelName": "RM_TEST_ADT_964_MOD",
+    "intelligentScenario": "RM_TEST_ADT_964",
+    "modellingContextId": "CFFE69A6585C4DFB6846A4C003FDCFE2",
     "modelType": "SAPGENAI",
     "adapterId": "SAPGENAI.Default",
     "nativeModelType": "SAPGENAI.Default",
     "state": "Published",
     "executableId": "azure-openai",
     "llmName": "gpt-4",
-    "llmModelVersion": "0613"
+    "llmVersion": "0613"
   },
-  "promptTemplates": [
+  "modelPromptTemplates": [
     {
-      "name": "SYSTEM_PROMPT",
-      "description": "System prompt",
+      "promptTemplateName": "SYSTEM_PROMPT",
+      "promptTemplateDescription": "System prompt",
       "prompt": "You are a sales executive who is responsible for reaching out to customers for confirming or declining their orders. Evaluate the size of the delivery vehicle based on the number of items. Calculate the distance between the billing and delivery location in kilometers. \n\nThe subject of email should be of format <Confirmation on order number: {order_number} placed on {booking_date}> \nThe body of email should be of format: \"\"\"\"SO contains <Category> to be delivered to <Location>. And will be delivered via a <size> vehicle. \nIF <distance between source address and delivery address> > 100 kms THEN include a message about potential delivery delays ELSE congratulate on being eligible for one day delivery",
       "promptParameters": "[]",
       "isVisible": true
     },
     {
-      "name": "USER_PROMPT",
-      "description": "User prompt",
+      "promptTemplateName": "USER_PROMPT",
+      "promptTemplateDescription": "User prompt",
       "prompt": "Build a confirmation mail for a sales order containing {ISLM_Items} where the items are categorized for example pencil and paper will be stationary, printer and mouse will be electronics. The source address contains {ISLM_Source} and the delivery address is in {ISLM_Destination}.",
       "promptParameters": "[{\"Name\":\"ISLM_Items\",\"Value\":\"\"},{\"Name\":\"ISLM_Source\",\"Value\":\"\"},{\"Name\":\"ISLM_Destination\",\"Value\":\"\"}]",
       "isVisible": true

diff --git a/file-formats/intm/intm-v1.json b/file-formats/intm/intm-v1.json
@@ -57,12 +57,12 @@
         "originalLanguage"
       ]
     },
-    "intelligentModel": {
+    "intelligentScenarioModel": {
       "title": "Intelligent Scenario Model",
       "description": "Intelligent scenario model",
       "type": "object",
       "properties": {
-        "name": {
+        "modelName": {
           "title": "Model Name",
           "description": "Model name",
           "type": "string",
@@ -125,7 +125,7 @@
           "type": "string"
         },
         "isEnhancement": {
-          "title": "Model flag",
+          "title": "Is Enhancement",
           "description": "If true, the model is an enhancement, if false the model is a new model.",
           "type": "boolean"
         },
@@ -140,16 +140,16 @@
           "description": "Large language model name",
           "type": "string"
         },
-        "llmModelVersion": {
-          "title": "LLM Model Version",
-          "description": "LLM model version",
+        "llmVersion": {
+          "title": "Large Language Model Version",
+          "description": "Large language model version",
           "type": "string",
           "maxLength": 30
         }
       },
       "additionalProperties": false
     },
-    "segmentFields": {
+    "modelSegmentFields": {
       "title": "Model Segment Fields",
       "description": "Model segment fields",
       "type": "array",
@@ -158,7 +158,7 @@
         "description": "Model segment field",
         "type": "object",
         "properties": {
-          "fieldname": {
+          "fieldName": {
             "title": "Field Name",
             "description": "Table or view field name",
             "type": "string",
@@ -180,7 +180,7 @@
         "additionalProperties": false
       }
     },
-    "promptTemplates": {
+    "modelPromptTemplates": {
       "title": "Model Prompt Templates",
       "description": "Model prompt templates",
       "type": "array",
@@ -189,14 +189,14 @@
         "description": "Model prompt template",
         "type": "object",
         "properties": {
-          "name": {
+          "promptTemplateName": {
             "title": "Prompt Template Name",
             "description": "Prompt template name",
             "type": "string",
             "maxLength": 30
           },
-          "description": {
-            "title": "Description",
+          "promptTemplateDescription": {
+            "title": "Prompt Template Description",
             "description": "Description of prompt template",
             "type": "string"
           },
@@ -218,7 +218,7 @@
         },
         "additionalProperties": false,
         "required": [
-          "name",
+          "promptTemplateName",
           "prompt"
         ]
       }
@@ -228,6 +228,6 @@
   "required": [
     "formatVersion",
     "header",
-    "intelligentModel"
+    "intelligentScenarioModel"
   ]
 }
diff --git a/file-formats/intm/type/zif_aff_intm_v1.intf.abap b/file-formats/intm/type/zif_aff_intm_v1.intf.abap
@@ -4,10 +4,10 @@ INTERFACE zif_aff_intm_v1
   TYPES:
     "! <p class="shorttext">Intelligent Scenario Model</p>
     "! Intelligent scenario model
-    BEGIN OF ty_intelligent_model,
+    BEGIN OF ty_intelligent_scenario_model,
       "! <p class="shorttext">Model Name</p>
       "! Model name
-      name                 TYPE c LENGTH 30,
+      model_name           TYPE c LENGTH 30,
       "! <p class="shorttext">Intelligent Scenario</p>
       "! Intelligent scenario of the model
       intelligent_scenario TYPE c LENGTH 20,
@@ -38,7 +38,7 @@ INTERFACE zif_aff_intm_v1
       "! <p class="shorttext">Bindings</p>
       "! Model bindings
       bindings             TYPE string,
-      "! <p class="shorttext">Model flag</p>
+      "! <p class="shorttext">Is Enhancement</p>
       "! If true, the model is an enhancement, if false the model is a new model.
       is_enhancement       TYPE abap_bool,
       "! <p class="shorttext">Executable ID</p>
@@ -47,17 +47,17 @@ INTERFACE zif_aff_intm_v1
       "! <p class="shorttext">Large Language Model Name</p>
       "! Large language model name
       llm_name             TYPE string,
-      "! <p class="shorttext">LLM Model Version</p>
-      "! LLM model version
-      llm_model_version    TYPE c LENGTH 30,
-    END OF ty_intelligent_model,
+      "! <p class="shorttext">Large Language Model Version</p>
+      "! Large language model version
+      llm_version          TYPE c LENGTH 30,
+    END OF ty_intelligent_scenario_model,
 
     "! <p class="shorttext">Segment Field</p>
     "! Model segment field
     BEGIN OF ty_segment_field,
       "! <p class="shorttext">Field Name</p>
       "! Table or view field name
-      fieldname      TYPE c LENGTH 30,
+      field_name     TYPE c LENGTH 30,
       "! <p class="shorttext">Position</p>
       "! Field position
       field_position TYPE i,
@@ -72,40 +72,40 @@ INTERFACE zif_aff_intm_v1
       "! <p class="shorttext">Prompt Template Name</p>
       "! Prompt template name
       "! $required
-      name              TYPE c LENGTH 30,
-      "! <p class="shorttext">Description</p>
+      prompt_template_name        TYPE c LENGTH 30,
+      "! <p class="shorttext">Prompt Template Description</p>
       "! Description of prompt template
-      description       TYPE string,
+      prompt_template_description TYPE string,
       "! <p class="shorttext">Prompt</p>
       "! Prompt
       "! $required
-      prompt            TYPE string,
+      prompt                      TYPE string,
       "! <p class="shorttext">Prompt Parameters</p>
       "! Prompt parameters
-      prompt_parameters TYPE string,
+      prompt_parameters           TYPE string,
       "! <p class="shorttext">Prompt Visibility</p>
       "! If true, the prompt is visible
-      is_visible        TYPE abap_bool,
+      is_visible                  TYPE abap_bool,
     END OF ty_prompt_template,
 
     "! <p class="shorttext">Intelligent scenario Models</p>
     "! Intelligent scenario model
     BEGIN OF ty_main,
       "! $required
-      format_version    TYPE zif_aff_types_v1=>ty_format_version,
+      format_version             TYPE zif_aff_types_v1=>ty_format_version,
       "! <p class="shorttext">Header</p>
       "! Header
       "! $required
-      header            TYPE zif_aff_types_v1=>ty_header_60,
+      header                     TYPE zif_aff_types_v1=>ty_header_60,
       "! <p class="shorttext">Intelligent Scenario Model</p>
       "! Intelligent scenario model
       "! $required
-      intelligent_model TYPE ty_intelligent_model,
+      intelligent_scenario_model TYPE ty_intelligent_scenario_model,
       "! <p class="shorttext">Model Segment Fields</p>
       "! Model segment fields
-      segment_fields    TYPE STANDARD TABLE OF ty_segment_field WITH DEFAULT KEY,
+      model_segment_fields       TYPE STANDARD TABLE OF ty_segment_field WITH DEFAULT KEY,
       "! <p class="shorttext">Model Prompt Templates</p>
       "! Model prompt templates
-      prompt_templates  TYPE STANDARD TABLE OF ty_prompt_template WITH DEFAULT KEY,
+      model_prompt_templates     TYPE STANDARD TABLE OF ty_prompt_template WITH DEFAULT KEY,
     END OF ty_main.
 ENDINTERFACE.