[EDCC] Add new object type for EDCC #661

KUMARMUKULSAP · 2024-09-17T02:08:20Z

No description provided.

GuilhermeSaraiva96

Hi, thank you for your aff. Definitely one of the biggest I have seen :)

GuilhermeSaraiva96 · 2024-09-30T13:23:28Z

file-formats/edcc/type/zif_aff_edcc_v1.intf.json

+{
+  "formatVersion": "1",
+  "header": {
+    "description": "AFF type for EDCK",


Suggested change

"description": "AFF type for EDCK",

"description": "AFF type for EDCC",

What does EDCC stand for?

GuilhermeSaraiva96 · 2024-09-30T13:25:41Z

file-formats/edcc/type/zif_aff_edcc_v1.intf.abap

+      message_type_description TYPE ty_short_description,
+      "! <p class="shorttext">Tax Authority Document Type</p>
+      "! Tax authority document type
+      taxauth_documenttype     TYPE c LENGTH 20,


tax_authority_document_type

file-formats/edcc/type/zif_aff_edcc_v1.intf.abap

GuilhermeSaraiva96 · 2024-09-30T13:30:52Z

file-formats/edcc/type/zif_aff_edcc_v1.intf.abap

+      original_language        TYPE zif_aff_types_v1=>ty_original_language,
+    END OF ty_message,
+    "! <p class="shorttext">Tax Authority Message Types</p>
+    "! Tax Authority Message types


Suggested change

"! Tax Authority Message types

"! Tax authority message types

Sentence case

file-formats/edcc/type/zif_aff_edcc_v1.intf.abap

KUMARMUKULSAP · 2024-10-03T07:39:18Z

@GuilhermeSaraiva96 : I have incorporated the above suggested changes. Please have a look and suggest if we can have a meeting to understand this AFF.

KUMARMUKULSAP · 2024-10-07T11:14:38Z

@GuilhermeSaraiva96 : Let us know if the AFF requires further adjustment

file-formats/edcc/type/zif_aff_edcc_v1.intf.abap

GuilhermeSaraiva96 · 2024-10-07T12:13:16Z

Hi, thank you for your changes, looks good already. I have just a few more suggestions. Additionally, could you please send a meeting request so that we can discuss the whole AFF before moving to the UX review? Thanks!

file-formats/edcc/examples/z_aff_example_edcc.edcc.json

KUMARMUKULSAP · 2024-10-17T06:32:28Z

@GuilhermeSaraiva96 : I have regenerated the examples and incorporated changes related to description of objects coming from other object types like EDCR/EDCK. Additionally I have added one new node in the AFF in ty_main, additional_selection_fields. Please have a look and let me know.

GuilhermeSaraiva96 · 2024-10-21T07:49:54Z

From my side, it is ready for the UX-Review. @nicolas?
Note for the UX Colleagues: the country field is an attribute directly at the root level. Should it be wrapped into a 'General Information' structure? Then it will be shown in the selection Detail instead of as grid in the root level

file-formats/edcc/type/zif_aff_edcc_v1.intf.abap

file-formats/edcc/type/zif_aff_edcc_v1.intf.json

KUMARMUKULSAP · 2024-10-24T11:33:43Z

@GuilhermeSaraiva96 : Above comments are fixed. please have a look

GuilhermeSaraiva96

Thanks! Looks good. Next time you can mark the comments as resolved, so that it is also easier to follow what has been changed, and what hasn't. Good job!

GuilhermeSaraiva96 · 2024-10-28T14:28:29Z

ready for UX Review

huber-nicolas · 2024-11-11T14:28:51Z

file-formats/edcc/type/zif_aff_edcc_v1.intf.abap

+      "! <p class="shorttext">Country</p>
+      "! Country
+      "! $required
+      country                     TYPE c LENGTH 3,


Can you please put the country field into a structure general_information

wurzka

Please see my comments

wurzka · 2024-11-27T15:42:40Z

file-formats/edcc/type/zif_aff_edcc_v1.intf.abap

+      "! <p class="shorttext">Country</p>
+      "! Country
+      "! $required
+      country                     TYPE c LENGTH 3,


What is this language field about? Are there any texts that must be translated?

wurzka · 2024-11-27T15:44:11Z

file-formats/edcc/type/zif_aff_edcc_v1.intf.abap

+      "! <p class="shorttext">Table Name</p>
+      "! Table name
+      table_name TYPE zif_aff_types_v1=>ty_object_name_30,
+      "! <p class="shorttext">Field Name</p>
+      "! Field name
+      field_name TYPE zif_aff_types_v1=>ty_object_name_30,
+      "! <p class="shorttext">Field Type</p>
+      "! Field type
+      field_type TYPE ty_field_type,


Is there any mandatory field? With this setting, I could add an entry to the table that is completely empty having only fieldType: selectOption

wurzka · 2024-11-27T15:45:15Z

file-formats/edcc/type/zif_aff_edcc_v1.intf.abap

+      "! <p class="shorttext">Table Name</p>
+      "! Table name
+      table_name TYPE zif_aff_types_v1=>ty_object_name_30,


Shouldn't this be required? Or can table_name be empty?

wurzka · 2024-11-27T15:45:55Z

file-formats/edcc/type/zif_aff_edcc_v1.intf.abap

+    "! <p class="shorttext">Comparison Type</p>
+    "! Comparison type


Suggested change

"! Comparison Type

"! Comparison type

"! Comparison Type Details

"! Comparison type

wurzka · 2024-11-27T15:47:24Z

file-formats/edcc/type/zif_aff_edcc_v1.intf.abap

+      "! <p class="shorttext">Comparison Type</p>
+      "! Comparison type
+      "! $required
+      comparison_type      TYPE zif_aff_types_v1=>ty_object_name_30,


This should be enough:

Suggested change

"! Comparison Type

"! Comparison type

"! $required

comparison_type TYPE zif_aff_types_v1=>ty_object_name_30,

"! Name

"! Comparison type

"! $required

name TYPE zif_aff_types_v1=>ty_object_name_30,

Besides that, is this an ABAP object? Or is this something that is defined in the EDCC object.
I wondered whether the description of the comparison type is correctly stored here

wurzka · 2024-11-27T16:14:11Z

file-formats/edcc/type/zif_aff_edcc_v1.intf.abap

+      "! <p class="shorttext">eDocument Type Assignment</p>
+      "! Assign eDocument types associated with consistency scenario
+      edocument_types             TYPE ty_edoc_types,


Suggested change

"! eDocument Type Assignment

"! Assign eDocument types associated with consistency scenario

edocument_types TYPE ty_edoc_types,

"! eDocument Types

"! Assign eDocument types associated with consistency scenario

edocument_types TYPE ty_edoc_types,

wurzka · 2024-11-27T16:14:33Z

file-formats/edcc/type/zif_aff_edcc_v1.intf.abap

+      "! eDocument Type
+      edoc_type TYPE c LENGTH 10,
+    END OF ty_edoc_type.
+  "! <p class="shorttext">eDocument Type Assignment</p>


Suggested change

"! eDocument Type Assignment

"! eDocument Types

wurzka · 2024-11-27T16:14:56Z

file-formats/edcc/type/zif_aff_edcc_v1.intf.abap

+      "! <p class="shorttext">eDocument Type</p>
+      "! eDocument Type
+      edoc_type TYPE c LENGTH 10,


Or only

Suggested change

"! eDocument Type

"! eDocument Type

edoc_type TYPE c LENGTH 10,

"! Type

"! eDocument Type

type TYPE c LENGTH 10,

Should this be a mandatory field?

wurzka · 2024-11-27T16:15:59Z

file-formats/edcc/type/zif_aff_edcc_v1.intf.abap

+      "! <p class="shorttext">Inconsistency Category</p>
+      "! Inconsistency category
+      result_ui_group  TYPE ty_resultgroup,


Suggested change

"! Inconsistency Category

"! Inconsistency category

result_ui_group TYPE ty_resultgroup,

"! Category

"! Inconsistency category

category TYPE ty_resultgroup,

wurzka · 2024-11-27T16:16:37Z

file-formats/edcc/type/zif_aff_edcc_v1.intf.abap

+      country_xtension TYPE zif_aff_types_v1=>ty_object_name_30,
+      "! <p class="shorttext">Result Processes</p>
+      "! Assign result process to the UI group
+      result_process   TYPE ty_result_processes,


These result processes have been there before (field of checks). Do we need them twice?

KUMARMUKULSAP and others added 7 commits September 17, 2024 07:38

[EDCC] Add new object type for EDCC

002ed00

adding examples

5da854b

commit abap lint fixes

81ac874

abap lint fixes

cc32868

EOL fix

bf14d4c

Read me fix

96f8345

Merge branch 'main' into feature/edcc

2ea5ecd

GuilhermeSaraiva96 requested changes Sep 30, 2024

View reviewed changes

Markus1812 added the new-object This is a new object type added to AFF label Oct 1, 2024

Merge branch 'main' into feature/edcc

37690a4

Markus1812 mentioned this pull request Oct 1, 2024

Update abaplint.jsonc #665

Merged

KUMARMUKULSAP added 4 commits October 3, 2024 11:23

Fixes for Guilherme's comment

525d0d4

apalint fixes

14c7d6e

abap lint fixes

6ed4cdb

Fixes in example file

283eda5

KUMARMUKULSAP requested a review from GuilhermeSaraiva96 October 3, 2024 07:39

GuilhermeSaraiva96 requested changes Oct 7, 2024

View reviewed changes

KUMARMUKULSAP added 3 commits October 9, 2024 13:26

Last Comment fixes for AFF

783e85e

Generated Schema error

510ed62

abap lint fixes

1c58269

GuilhermeSaraiva96 reviewed Oct 14, 2024

View reviewed changes

file-formats/edcc/examples/z_aff_example_edcc.edcc.json Outdated Show resolved Hide resolved

KUMARMUKULSAP added 2 commits October 17, 2024 11:54

Changes after online review

a510956

ABAP Lint fix

4d56863

GuilhermeSaraiva96 self-requested a review October 22, 2024 09:21

GuilhermeSaraiva96 reviewed Oct 22, 2024

View reviewed changes

file-formats/edcc/type/zif_aff_edcc_v1.intf.abap Outdated Show resolved Hide resolved

file-formats/edcc/type/zif_aff_edcc_v1.intf.json Outdated Show resolved Hide resolved

albertmink and others added 7 commits October 23, 2024 09:08

Merge branch 'main' into feature/edcc

771c3ea

Fix of latest comments

f5856ed

abap lint fix

6b72ee2

corrections to abap_lint

a438a33

Commit to older comments

026ebce

commit to abap lint

1bddfda

abap_lint fix

2f6621a

KUMARMUKULSAP requested a review from GuilhermeSaraiva96 October 28, 2024 06:14

GuilhermeSaraiva96 approved these changes Oct 28, 2024

View reviewed changes

Merge branch 'main' into feature/edcc

d74208b

GuilhermeSaraiva96 added ux-review ready AFF is ready for UX review and removed new-object This is a new object type added to AFF labels Oct 29, 2024

huber-nicolas reviewed Nov 11, 2024

View reviewed changes

Merge branch 'main' into feature/edcc

452b477

wurzka requested changes Nov 27, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[EDCC] Add new object type for EDCC #661

[EDCC] Add new object type for EDCC #661

KUMARMUKULSAP commented Sep 17, 2024

GuilhermeSaraiva96 left a comment

GuilhermeSaraiva96 Sep 30, 2024

GuilhermeSaraiva96 Sep 30, 2024

GuilhermeSaraiva96 Sep 30, 2024

KUMARMUKULSAP commented Oct 3, 2024

KUMARMUKULSAP commented Oct 7, 2024

GuilhermeSaraiva96 commented Oct 7, 2024

KUMARMUKULSAP commented Oct 17, 2024

GuilhermeSaraiva96 commented Oct 21, 2024

KUMARMUKULSAP commented Oct 24, 2024

GuilhermeSaraiva96 left a comment

GuilhermeSaraiva96 commented Oct 28, 2024

huber-nicolas Nov 11, 2024

wurzka left a comment

wurzka Nov 27, 2024

wurzka Nov 27, 2024

wurzka Nov 27, 2024

wurzka Nov 27, 2024

wurzka Nov 27, 2024

wurzka Nov 27, 2024

wurzka Nov 27, 2024

wurzka Nov 27, 2024

wurzka Nov 27, 2024

wurzka Nov 27, 2024

wurzka Nov 27, 2024

wurzka Nov 27, 2024

	"description": "AFF type for EDCK",
	"description": "AFF type for EDCC",

	"! Tax Authority Message types
	"! Tax authority message types

		"! <p class="shorttext">Comparison Type</p>
		"! Comparison type

	"! <p class="shorttext">eDocument Type Assignment</p>
	"! <p class="shorttext">eDocument Types</p>

[EDCC] Add new object type for EDCC #661

Are you sure you want to change the base?

[EDCC] Add new object type for EDCC #661

Conversation

KUMARMUKULSAP commented Sep 17, 2024

GuilhermeSaraiva96 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

KUMARMUKULSAP commented Oct 3, 2024

KUMARMUKULSAP commented Oct 7, 2024

GuilhermeSaraiva96 commented Oct 7, 2024

KUMARMUKULSAP commented Oct 17, 2024

GuilhermeSaraiva96 commented Oct 21, 2024

KUMARMUKULSAP commented Oct 24, 2024

GuilhermeSaraiva96 left a comment

Choose a reason for hiding this comment

GuilhermeSaraiva96 commented Oct 28, 2024

Choose a reason for hiding this comment

wurzka left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment