-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: context menus based on project type #132
Conversation
This pull request introduces 1 alert when merging 43312e2 into fbbf234 - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging 23c3667 into fbbf234 - view on LGTM.com new alerts:
|
This pull request introduces 3 alerts when merging 22e5efc into fbbf234 - view on LGTM.com new alerts:
|
This pull request introduces 3 alerts when merging e4fdd2e into fbbf234 - view on LGTM.com new alerts:
|
This pull request introduces 3 alerts when merging 7362c9d into fbbf234 - view on LGTM.com new alerts:
|
7709f49
to
87a54bb
Compare
This pull request introduces 1 alert when merging e0694df into 8f3e6b4 - view on LGTM.com new alerts:
|
@@ -60,6 +63,7 @@ | |||
"shx": "^0.3.3", | |||
"rimraf": "^3.0.2", | |||
"patch-package": "6.4.7", | |||
"ts-node": "^10.4.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ts-node does not always work well with monorepos + typescript
@@ -25,6 +31,26 @@ export function activate(context: ExtensionContext): BasToolkit { | |||
const basToolkitAPI = createBasToolkitAPI(workspaceAPI, baseBasToolkitAPI); | |||
|
|||
const logger = getLogger().getChildLogger({ label: "activate" }); | |||
// using `.then` instead of `await` to keep the activate function synchronized | |||
// to avoid automatic wrapping of `BasToolKit` API in a promise. | |||
workspaceAPI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we may want to extract the initial setup of the tags to a utility function
13ebdce
to
50c905c
Compare
This reverts commit 87a54bb.
…red + README.md updated
66c7073
to
34ac1b0
Compare
No description provided.