Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: 💡 [HCPSDKFIORIUIKIT-2891]FilterFeedbackBarItem #969

Conversation

restaurantt
Copy link
Collaborator

No description provided.

@restaurantt restaurantt requested a review from a team as a code owner January 23, 2025 09:36
@restaurantt restaurantt requested review from billzhou0223 and removed request for a team January 23, 2025 09:36
// sourcery: no_view
var isSelected: Bool { get }
}

@available(*, unavailable, renamed: "_FilterFeedbackBarItemModel", message: "Will be removed in the future release. Please use FilterFeedbackBarItem instead.")
public protocol FilterFeedbackBarItemModel {}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing Docs Violation: public declarations should be documented. (missing_docs)

}
return nil
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File Length Violation: File should contain 700 lines or less: currently contains 977 (file_length)

// sourcery: no_view
var isSelected: Bool { get }
}

@available(*, unavailable, renamed: "_FilterFeedbackBarItemModel", message: "Will be removed in the future release. Please use FilterFeedbackBarItem instead.")
public protocol FilterFeedbackBarItemModel {}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing Docs Violation: public declarations should be documented. (missing_docs)

}
return nil
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File Length Violation: File should contain 700 lines or less: currently contains 977 (file_length)

// sourcery: no_view
var isSelected: Bool { get }
}

@available(*, unavailable, renamed: "_FilterFeedbackBarItemModel", message: "Will be removed in the future release. Please use FilterFeedbackBarItem instead.")
public protocol FilterFeedbackBarItemModel {}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing Docs Violation: public declarations should be documented. (missing_docs)

}
return nil
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File Length Violation: File should contain 700 lines or less: currently contains 977 (file_length)

@dyongxu dyongxu requested a review from xiaoyu0722 January 23, 2025 23:41
import Foundation
import SwiftUI

/**
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orphaned Doc Comment Violation: A doc comment should be attached to a declaration. (orphaned_doc_comment)

Copy link
Contributor

@dyongxu dyongxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to resolve merge conflict

@restaurantt
Copy link
Collaborator Author

Need to resolve merge conflict

Conflicts are resolved.

@restaurantt restaurantt requested a review from dyongxu February 6, 2025 01:45
@dyongxu dyongxu merged commit 4544313 into SAP:main Feb 6, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants