feat: 🎸 HCPSDKFIORIUIKIT-2920 Add position parameter to Toast Message #975
+151
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuliaSchnSAP
requested review from
billzhou0223
and removed request for
a team
dyongxu
reviewed
Feb 10, 2025
| @@ -11,21 +11,50 @@ import SwiftUI | |||
| 4. Move this file to `_FioriStyles` folder under `FioriSwiftUICore`. | |||
| */ | |||
|
|
|||
| public enum ToastMessagePosition: String, CaseIterable, Identifiable { | |||
There was a problem hiding this comment.
add API doc: what these position alignment mean visually, relative to the reference view.
dyongxu
reviewed
Feb 10, 2025
| @@ -132,15 +167,18 @@ public extension View { | |||
| /// - icon: Icon image in front of the text. The default is a checkmark icon. | |||
| /// - title: The message to display. | |||
| /// - duration: The duration in seconds for which the toast message is shown. The default is `1`. | |||
| /// - position: The position of the toast message relative to its parent view. The default is `.center`. | |||
There was a problem hiding this comment.
what is the spacing btw toast message and parent view ?
There was a problem hiding this comment.
There is no spacing
There was a problem hiding this comment.
Since there will be use cases where spacing is needed, let's provide a new property to allow the spacing.
…ion' into toast-message-position
…ion' into toast-message-position
JuliaSchnSAP
changed the title
dyongxu
approved these changes
Feb 25, 2025
|
…ion' into toast-message-position
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.