refactor: 💡 [HCPSDKFIORIUIKIT-2891]FilterFeedbackBar refactor #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iori into main-HCPSDKFIORIUIKIT-2891-FilterFeedbackBarModel # Conflicts: # Sources/FioriSwiftUICore/Models/ModelDefinitions.swift # Sources/FioriSwiftUICore/_ComponentProtocols/CompositeComponentProtocols.swift # Sources/FioriSwiftUICore/_generated/Components/EnvironmentKey+Styles.generated.swift # Sources/FioriSwiftUICore/_generated/Components/EnvironmentValue+Styles.generated.swift # Sources/FioriSwiftUICore/_generated/ViewModels/API/SearchListPickerItem+API.generated.swift # Sources/FioriSwiftUICore/_generated/ViewModels/API/_SignatureCaptureView+API.generated.swift # sourcery/.lib/Sources/utils/Type+Extensions.swift
restaurantt
requested review from
billzhou0223
and removed request for
a team
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -522,6 +522,9 @@ public protocol FilterFeedbackBarModel: AnyObject { | |||
| var onUpdate: (() -> Void)? { get set } | |||
| } | |||
|
|
|||
| @available(*, unavailable, renamed: "_FilterFeedbackBarModel", message: "Will be removed in the future release. Please use FilterFeedbackBar instead.") | |||
| public protocol FilterFeedbackBarModel {} | |||
There was a problem hiding this comment.
Missing Docs Violation: public declarations should be documented. (missing_docs)
| @@ -522,6 +522,9 @@ public protocol FilterFeedbackBarModel: AnyObject { | |||
| var onUpdate: (() -> Void)? { get set } | |||
| } | |||
|
|
|||
| @available(*, unavailable, renamed: "_FilterFeedbackBarModel", message: "Will be removed in the future release. Please use FilterFeedbackBar instead.") | |||
| public protocol FilterFeedbackBarModel {} | |||
There was a problem hiding this comment.
Missing Docs Violation: public declarations should be documented. (missing_docs)
| import Foundation | ||
| import SwiftUI | ||
|
|
||
| /** |
There was a problem hiding this comment.
Orphaned Doc Comment Violation: A doc comment should be attached to a declaration. (orphaned_doc_comment)
| import Foundation | ||
| import SwiftUI | ||
|
|
||
| /** |
There was a problem hiding this comment.
Orphaned Doc Comment Violation: A doc comment should be attached to a declaration. (orphaned_doc_comment)
dyongxu
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.